[tools] Extend tools/regexp-sequences.py [v8/v8 : main]

0 views
Skip to first unread message

Jakob Linke (Gerrit)

unread,
5:17 AM (18 hours ago) 5:17 AM
to Patrick Thier, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Patrick Thier

Jakob Linke voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Patrick Thier
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I8e0f59865d5da3c5aadfbbfa80cc6dae89622f3a
Gerrit-Change-Number: 7415268
Gerrit-PatchSet: 3
Gerrit-Owner: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Patrick Thier <pth...@chromium.org>
Gerrit-Attention: Patrick Thier <pth...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 10:17:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Patrick Thier (Gerrit)

unread,
5:20 AM (18 hours ago) 5:20 AM
to Jakob Linke, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Jakob Linke

Patrick Thier voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Jakob Linke
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I8e0f59865d5da3c5aadfbbfa80cc6dae89622f3a
Gerrit-Change-Number: 7415268
Gerrit-PatchSet: 3
Gerrit-Owner: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Patrick Thier <pth...@chromium.org>
Gerrit-Attention: Jakob Linke <jgr...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 10:20:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
5:51 AM (18 hours ago) 5:51 AM
to Jakob Linke, Patrick Thier, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[tools] Extend tools/regexp-sequences.py

This adds loop detection and sequence canonicalization. For loop
sequences (i.e. where the last bytecode jumps back to the first), we now
print how often the backedge is taken. And we canonicalize sequences so
they are printed in ascending pc order.

Output:

SkipUntilOneOfMasked --> LoadCurrentCharacter -->
CheckNotCharacterAfterAnd --> AdvanceCpAndGoto: 15489 (67.23 %) - Loops:
12402 (80.07 %)
Change-Id: I8e0f59865d5da3c5aadfbbfa80cc6dae89622f3a
Auto-Submit: Jakob Linke <jgr...@chromium.org>
Reviewed-by: Patrick Thier <pth...@chromium.org>
Commit-Queue: Jakob Linke <jgr...@chromium.org>
Commit-Queue: Patrick Thier <pth...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104591}
Files:
  • M tools/regexp-sequences.py
Change size: M
Delta: 1 file changed, 73 insertions(+), 15 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Patrick Thier
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I8e0f59865d5da3c5aadfbbfa80cc6dae89622f3a
Gerrit-Change-Number: 7415268
Gerrit-PatchSet: 4
Gerrit-Owner: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Reviewer: Patrick Thier <pth...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages