[*lev] Inline AsyncFunctionEnter [v8/v8 : main]
0 views
Skip to first unread message
Darius Mercadier (Gerrit)
Jan 9, 2026, 6:25:15 AM (yesterday) Jan 9
to Victor Gomes, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Jan 9, 2026, 7:11:14 AM (yesterday) Jan 9
to Darius Mercadier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier
Victor Gomes added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Victor Gomes . resolved
Nice, LGTM. Any idea why we regress Air?
Commit Message
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Jan 9, 2026, 7:11:41 AM (yesterday) Jan 9
to Darius Mercadier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier
Victor Gomes voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Jan 9, 2026, 7:23:24 AM (yesterday) Jan 9
to Victor Gomes, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Darius Mercadier voted and added 2 comments![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Auto-Submit | +1 |
Nice, LGTM. Any idea why we regress Air?
Darius Mercadier
Mmmh good question, I'll trigger another pinpoint and if it still repros I'll have a quick look before landing :)
(marking this as unresolved so that I don't forget before landing)
Commit Message
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 9, 2026, 8:24:54 AM (yesterday) Jan 9
to Darius Mercadier, Victor Gomes, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier and Victor Gomes
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream-main.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/10eb5cdeb10000
Related details
Attention is currently required from:
- Darius Mercadier
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 9, 2026, 8:26:53 AM (yesterday) Jan 9
to Darius Mercadier, Victor Gomes, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier and Victor Gomes
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m4-mini-perf/jetstream-main.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/13389519b10000
Darius Mercadier (Gerrit)
Jan 9, 2026, 8:30:26 AM (yesterday) Jan 9
to Victor Gomes, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Commit-Queue | +2 |
Darius MercadierNice, LGTM. Any idea why we regress Air?
Mmmh good question, I'll trigger another pinpoint and if it still repros I'll have a quick look before landing :)
(marking this as unresolved so that I don't forget before landing)
Darius Mercadier
Air doesn't regress anymore; looks like it was noise.
async-fs regresses on M1 but improves on M4 so I'm going to call this noise as well and go ahead with landing.
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 9, 2026, 8:32:27 AM (yesterday) Jan 9
to Darius Mercadier, Victor Gomes, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[*lev] Inline AsyncFunctionEnter
Bug: 431933185
Change-Id: I3aecc10b27683d855c6d237dea57d6dec245a8c5
Reviewed-by: Victor Gomes <victo...@chromium.org>
Auto-Submit: Darius Mercadier <dmerc...@chromium.org>
Commit-Queue: Darius Mercadier <dmerc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104597}
Files:
- M src/maglev/maglev-graph-builder.cc
- M src/maglev/maglev-graph-builder.h
- M src/maglev/maglev-ir.h
Change size: M
Delta: 3 files changed, 143 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Victor Gomes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages