[wasm interpreter] Call wasm function directly in CallRef [v8/v8 : main]
王忠齐 (Gerrit)
王忠齐 added 1 comment![]( "Open in Gerrit")
Related details
- Paolo Severini
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Lehmann (Gerrit)
Daniel Lehmann voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Lehmann
| Code-Review | +1 |
1 comment
Rubber stamping interpreter-only change, I'll let Paolo comment on the actual review.
Related details
- Paolo Severini
- 王忠齐
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paolo Severini (Gerrit)
Paolo Severini added 4 comments![]( "Open in Gerrit")
Looks very good to me, with two comments.
DirectHandle<WasmFuncRef> wasm_func_ref = Cast<WasmFuncRef>(func_ref);
Tagged<WasmInternalFunction> internal = wasm_func_ref->internal(isolate_);
DirectHandle<Object> object_implicit_arg{internal->implicit_arg(), isolate_};Thanks! This simplify the logic a lot!
ExternalCallResult WasmInterpreterRuntime::CallExternalWasmFunction(This is all good but maybe just the function name is confusing because we do not always call an external Wasm function, we might also call a function in the same instance.
'wasm/nan-constant': [SKIP],This test contains the directive:
```
%WasmTierUpFunction(wasm.main);
```
which cannot work with the interpreter, so it will still fail, I believe, even though for a different reason.
Related details
- 王忠齐
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
王忠齐 (Gerrit)
王忠齐 added 2 comments![]( "Open in Gerrit")
ExternalCallResult WasmInterpreterRuntime::CallExternalWasmFunction(This is all good but maybe just the function name is confusing because we do not always call an external Wasm function, we might also call a function in the same instance.
Currently only CallRef may call into this function with the same instance. And I have see a TODO mentioned that we can call directly when the current wasm instance is same with instance in the wasm FuncRef. So I planned fix the return_call_ref in wasm-spec-test by this way. After it, a DCHECK will be add into CallExternalWasmFunction to keep the wasm function is external. Maybe I can add a TODO in ExecuteCallRef before I do it in my next CL.
'wasm/nan-constant': [SKIP],This test contains the directive:
```
%WasmTierUpFunction(wasm.main);
```
which cannot work with the interpreter, so it will still fail, I believe, even though for a different reason.
Thanks, add this test case into "Tests using %WasmTierUpFunction()" is a good choice.
Related details
- Daniel Lehmann
- Paolo Severini
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Lehmann (Gerrit)
Daniel Lehmann voted Code-Review+1![]( "Open in Gerrit")
- Paolo Severini
- 王忠齐
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paolo Severini (Gerrit)
Paolo Severini voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
- 王忠齐
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paolo Severini (Gerrit)
Paolo Severini voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
- 王忠齐
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[wasm interpreter] Call wasm function directly in CallRef
To pass the test case in nan-constant.js, we cannt't call a wasm func
ref by its JSFunction entry. Because the has f32 nan bitset been changed
after we call into JSFunction.
- M src/wasm/interpreter/wasm-interpreter-runtime.cc
- M src/wasm/interpreter/wasm-interpreter-runtime.h
- M test/mjsunit/mjsunit.status
Code-Review: +1 by Paolo Severini, +1 by Daniel Lehmann
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |