[profiling] Fix custom perf option [v8/v8 : main]
0 views
Skip to first unread message
Rezvan Mahdavi Hezaveh (Gerrit)
Jun 29, 2026, 7:06:54 PM (2 days ago) Jun 29
to Daniel Lehmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Daniel Lehmann
Rezvan Mahdavi Hezaveh added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Rezvan Mahdavi Hezaveh . resolved
This CL is ready for review, PTAL. Thanks!
Related details
Attention is currently required from:
- Daniel Lehmann
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Lehmann (Gerrit)
Jun 29, 2026, 7:07:25 PM (2 days ago) Jun 29
to Rezvan Mahdavi Hezaveh, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Rezvan Mahdavi Hezaveh
Daniel Lehmann voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Lehmann
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Rezvan Mahdavi Hezaveh
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rezvan Mahdavi Hezaveh (Gerrit)
Jun 30, 2026, 12:49:07 PM (yesterday) Jun 30
to Camillo Bruni, Daniel Lehmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Camillo Bruni
Rezvan Mahdavi Hezaveh added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Rezvan Mahdavi Hezaveh . resolved
Not sure why this CL needs more than one +1. Camillo, can you take a look and stamp the CL? Thanks.
Related details
Attention is currently required from:
- Camillo Bruni
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Camillo Bruni (Gerrit)
4:14 AM (17 hours ago) 4:14 AM
to Rezvan Mahdavi Hezaveh, Daniel Lehmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Rezvan Mahdavi Hezaveh
Camillo Bruni voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Rezvan Mahdavi Hezaveh
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rezvan Mahdavi Hezaveh (Gerrit)
12:05 PM (9 hours ago) 12:05 PM
to Camillo Bruni, Daniel Lehmann, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Rezvan Mahdavi Hezaveh voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
12:52 PM (8 hours ago) 12:52 PM
to Rezvan Mahdavi Hezaveh, Camillo Bruni, Daniel Lehmann, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[profiling] Fix custom perf option
The `linux-perf-chrome.py` only recognized the perf options
if they are prefixed with `--perf`. This CL append this prefix
to the perf options, such as `--freq`.
TAG=agy
Change-Id: I28d9dff163cfd24b5c940c2e0d510db81d26d620
Reviewed-by: Daniel Lehmann <dleh...@chromium.org>
Reviewed-by: Camillo Bruni <cbr...@chromium.org>
Commit-Queue: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108379}
Files:
- M tools/profiling/linux-perf-chrome.py
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Camillo Bruni, +1 by Daniel Lehmann
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages