[turboshaft] micro-optimization of StringSlice.end computation [v8/v8 : main]
0 views
Skip to first unread message
Darius Mercadier (Gerrit)
Dec 9, 2025, 7:17:19 AM12/9/25
to Marja Hölttä, V8 LUCI CQ, AyeAye, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Marja Hölttä
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Marja Hölttä
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marja Hölttä (Gerrit)
Dec 9, 2025, 8:45:53 AM12/9/25
to Darius Mercadier, V8 LUCI CQ, AyeAye, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Darius Mercadier
Marja Hölttä voted![]( "Open in Gerrit")
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Dec 9, 2025, 8:47:30 AM12/9/25
to Darius Mercadier, Marja Hölttä, AyeAye, dmercadi...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[turboshaft] micro-optimization of StringSlice.end computation
This is just to make branch prediction a bit better: string.length()
is not a special case anymore for the value of "end" in StringSlice
and will go into the same path as values less than length.
Bug: 431933185
Change-Id: I46feed78ee853e818dc8d990e0beeb8ba8e209b1
Reviewed-by: Marja Hölttä <ma...@chromium.org>
Auto-Submit: Darius Mercadier <dmerc...@chromium.org>
Commit-Queue: Marja Hölttä <ma...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104200}
Files:
- M src/compiler/turboshaft/machine-lowering-reducer-inl.h
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Marja Hölttä
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages