[wasm][jspi] Rename STACK_SWITCH frame type to WASM_JSPI [v8/v8 : main]
0 views
Skip to first unread message
Thibaud Michaud (Gerrit)
Aug 28, 2025, 9:23:28 AM (10 days ago) Aug 28
to Igor Sheludko, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Igor Sheludko
Thibaud Michaud added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Thibaud Michaud . resolved
PTAL, just a rename, no functional changes.
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Aug 28, 2025, 9:45:11 AM (10 days ago) Aug 28
to Thibaud Michaud, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Thibaud Michaud
Igor Sheludko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Thibaud Michaud
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thibaud Michaud (Gerrit)
Aug 28, 2025, 9:45:42 AM (10 days ago) Aug 28
to Igor Sheludko, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Thibaud Michaud voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Aug 28, 2025, 10:33:33 AM (10 days ago) Aug 28
to Thibaud Michaud, Igor Sheludko, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[wasm][jspi] Rename STACK_SWITCH frame type to WASM_JSPI
And StackSwitchFrame to WasmJspiFrame, to avoid future confusions with
wasmfx frame types.
R=clem...@chromium.org
Bug: 388533754,42202153
Change-Id: I133dea42f37278df11257d896f4b99a68393f0af
Commit-Queue: Thibaud Michaud <thib...@chromium.org>
Reviewed-by: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102104}
Files:
- M src/builtins/arm/builtins-arm.cc
- M src/builtins/arm64/builtins-arm64.cc
- M src/builtins/ia32/builtins-ia32.cc
- M src/builtins/x64/builtins-x64.cc
- M src/execution/frame-constants.h
- M src/execution/frames-inl.h
- M src/execution/frames.cc
- M src/execution/frames.h
- M src/execution/isolate.cc
Change size: L
Delta: 9 files changed, 161 insertions(+), 184 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Igor Sheludko
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thibaud Michaud (Gerrit)
Aug 28, 2025, 10:53:55 AM (10 days ago) Aug 28
to Kasper Lund, v8-re...@googlegroups.com
Attention needed from Kasper Lund
Thibaud Michaud voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Kasper Lund
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kasper Lund (Gerrit)
Aug 28, 2025, 10:54:52 AM (10 days ago) Aug 28
to Thibaud Michaud, v8-re...@googlegroups.com
Kasper Lund voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kasper Lund (Gerrit)
Aug 28, 2025, 10:55:19 AM (10 days ago) Aug 28
to V8 LUCI CQ, Thibaud Michaud, v8-re...@googlegroups.com
Kasper Lund voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kasper Lund (Gerrit)
Aug 28, 2025, 10:59:46 AM (10 days ago) Aug 28
to V8 LUCI CQ, Thibaud Michaud, v8-re...@googlegroups.com
Kasper Lund voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Aug 28, 2025, 11:30:29 AM (10 days ago) Aug 28
to Kasper Lund, Thibaud Michaud, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[riscv][wasm][jspi] Rename STACK_SWITCH frame type to WASM_JSPI
Port commit b613c09de0e1aae7b197a8baf03895b2b6cf70be.
Bug: 388533754,42202153
Change-Id: Ib4166faaa78c94160680cea9d112b114bc3cf5c9
Reviewed-by: Thibaud Michaud <thib...@chromium.org>
Commit-Queue: Kasper Lund <kas...@rivosinc.com>
Cr-Commit-Position: refs/heads/main@{#102109}
Files:
- M src/builtins/riscv/builtins-riscv.cc
Change size: M
Delta: 1 file changed, 36 insertions(+), 44 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thibaud Michaud
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zhao Jiazhong (Gerrit)
Aug 29, 2025, 4:41:14 AM (9 days ago) Aug 29
to Thibaud Michaud, v8-loongar...@chromium.org, v8-re...@googlegroups.com
Attention needed from Thibaud Michaud
Zhao Jiazhong voted and added 1 comment![]( "Open in Gerrit")
Votes added by Zhao Jiazhong
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Thibaud Michaud
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zhao Jiazhong (Gerrit)
Sep 4, 2025, 3:22:57 AM (3 days ago) Sep 4
to Thibaud Michaud, v8-loongar...@chromium.org, v8-re...@googlegroups.com
Attention needed from Thibaud Michaud
Zhao Jiazhong added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Zhao Jiazhong . resolved
Hi Thibaud, could you help to review this CL, thanks!
Related details
Attention is currently required from:
- Thibaud Michaud
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thibaud Michaud (Gerrit)
Sep 4, 2025, 8:05:44 AM (3 days ago) Sep 4
to Zhao Jiazhong, v8-loongar...@chromium.org, v8-re...@googlegroups.com
Attention needed from Zhao Jiazhong
Thibaud Michaud voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thibaud Michaud
| Code-Review | +1 |
1 comment
Patchset-level comments
Zhao Jiazhong . resolved
Hi Thibaud, could you help to review this CL, thanks!
Thibaud Michaud
Sorry, I missed this somehow, thanks for the ping. LGTM.
Related details
Attention is currently required from:
- Zhao Jiazhong
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zhao Jiazhong (Gerrit)
Sep 4, 2025, 8:56:31 PM (3 days ago) Sep 4
to Thibaud Michaud, v8-loongar...@chromium.org, v8-re...@googlegroups.com
Zhao Jiazhong voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Sep 4, 2025, 9:34:37 PM (3 days ago) Sep 4
to Zhao Jiazhong, Thibaud Michaud, v8-loongar...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[loong64][wasm][jspi] Rename STACK_SWITCH frame type to WASM_JSPI
Port commit b613c09de0e1aae7b197a8baf03895b2b6cf70be
Change-Id: I12a0b972c6997a480a372dcbbf547be31fc285c1
Auto-Submit: Zhao Jiazhong <zhaojia...@loongson.cn>
Reviewed-by: Thibaud Michaud <thib...@chromium.org>
Commit-Queue: Zhao Jiazhong <zhaojia...@loongson.cn>
Cr-Commit-Position: refs/heads/main@{#102256}
Files:
- M src/builtins/loong64/builtins-loong64.cc
Change size: M
Delta: 1 file changed, 30 insertions(+), 35 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thibaud Michaud
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages