[turboshaft] Prevent GVN during lowering of LoadTrustedPointer [v8/v8 : main]
0 views
Skip to first unread message
Darius Mercadier (Gerrit)
Jan 2, 2026, 5:00:19 AM (7 days ago) Jan 2
to Leszek Swirski, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Darius Mercadier voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 2, 2026, 5:02:03 AM (7 days ago) Jan 2
to Darius Mercadier, Leszek Swirski, dmercadi...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[turboshaft] Prevent GVN during lowering of LoadTrustedPointer
Bug: 471363817
Change-Id: I5d26c5c0566f7db255f88e56e8a7a5ff320fe249
Reviewed-by: Leszek Swirski <les...@chromium.org>
Auto-Submit: Darius Mercadier <dmerc...@chromium.org>
Commit-Queue: Darius Mercadier <dmerc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104473}
Files:
- M src/compiler/turboshaft/load-store-simplification-reducer.h
- A test/mjsunit/wasm/regress-471363817.js
Change size: M
Delta: 2 files changed, 88 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Leszek Swirski
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthias Liedtke (Gerrit)
Jan 8, 2026, 7:09:13 AM (23 hours ago) Jan 8
to Darius Mercadier, V8 LUCI CQ, Leszek Swirski, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Darius Mercadier
Matthias Liedtke added 1 comment![]( "Open in Gerrit")
File src/compiler/turboshaft/load-store-simplification-reducer.h
Line 153, Patchset 3 (Latest):
V<Word32> table_index =
__ Word32ShiftRightLogical(handle, kTrustedPointerHandleShift);
V<Word64> table_offset = __ ChangeUint32ToUint64(
__ Word32ShiftLeft(table_index, kTrustedPointerTableEntrySizeLog2));Matthias Liedtke . unresolved
Is there a good reason to prevent GVN'ing these specific operations?
Note that my code changes were caused by the issues of conceptually immutable trusted loads still causing many unnecessary repeated calculations (including loads). This will probably re-add at least some of them.
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages