[wasm interpreter] Use r0/fp0 as a Register instanding a Value [v8/v8 : main]

[王忠齐 (Gerrit)]

王忠齐 removed v8-re...@googlegroups.com from this change

Deleted Reviewers:

• v8-re...@googlegroups.com

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: deleteReviewer

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Ib75aaa538a5a60285b4759d2e9657e9b2881fb83

Gerrit-Change-Number: 7156793

Gerrit-PatchSet: 1

Gerrit-Owner: 王忠齐 <wzq225...@gmail.com>

[Jakob Kummerow (Gerrit)]

Attention needed from Paolo Severini and 王忠齐

王忠齐 has uploaded the change for review

Jakob Kummerow removed was...@google.com from reviewers of this change.

Commit message

[wasm interpreter] Use r0/fp0 as a Register instanding a Value

Use r0/fp0 as a Register instanding a value of type int64_t/double.
In f32.reinterpret.i32, we implicitly convert f32 to f64, which may
change the value we saved when the i32 value represented a f32:nan.

Bug: 460940948

Change-Id: Ib75aaa538a5a60285b4759d2e9657e9b2881fb83

Change diff

Change information

Files:

• M src/wasm/interpreter/wasm-interpreter.cc
• M src/wasm/interpreter/x64/interpreter-builtins-x64.cc
• A test/mjsunit/compiler/regress-460940948.js

Change size: L

Delta: 3 files changed, 192 insertions(+), 133 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

• Paolo Severini
• 王忠齐

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Ib75aaa538a5a60285b4759d2e9657e9b2881fb83

Gerrit-Change-Number: 7156793

Gerrit-PatchSet: 5

Gerrit-Owner: 王忠齐 <wzq225...@gmail.com>

Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>

Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: 王忠齐 <wzq225...@gmail.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Paolo Severini <paol...@microsoft.com>

Gerrit-Attention: 王忠齐 <wzq225...@gmail.com>

[Jakob Kummerow (Gerrit)]

Attention needed from Paolo Severini and 王忠齐

Jakob Kummerow added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Jakob Kummerow . resolved

The test should be in `test/mjsunit/wasm/` so that it gets skipped on non-Wasm-enabled configurations.

(I have no opinion on this change otherwise; I'll rubberstamp it if/when Paolo is happy with it.)

Open in Gerrit

Related details

Attention is currently required from:

• Paolo Severini
• 王忠齐

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Ib75aaa538a5a60285b4759d2e9657e9b2881fb83

Gerrit-Change-Number: 7156793

Gerrit-PatchSet: 5

Gerrit-Owner: 王忠齐 <wzq225...@gmail.com>

Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>

Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>

Gerrit-Reviewer: 王忠齐 <wzq225...@gmail.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Paolo Severini <paol...@microsoft.com>

Gerrit-Attention: 王忠齐 <wzq225...@gmail.com>

Gerrit-Comment-Date: Tue, 18 Nov 2025 15:52:04 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No