[wasm] Avoid deadlock in single-threaded streaming compilation [v8/v8 : main]
0 views
Skip to first unread message
Clemens Backes (Gerrit)
11:29 AM (11 hours ago) 11:29 AM
to v8-s...@luci-project-accounts.iam.gserviceaccount.com, Jakob Kummerow, v8-re...@googlegroups.com, was...@google.com
Attention needed from Jakob Kummerow
Clemens Backes added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Jakob Kummerow
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
11:40 AM (11 hours ago) 11:40 AM
to Clemens Backes, Jakob Kummerow, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com, was...@google.com
Attention needed from Clemens Backes
Jakob Kummerow voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Clemens Backes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
1:48 PM (9 hours ago) 1:48 PM
to Jakob Kummerow, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com, was...@google.com
Clemens Backes voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
1:50 PM (9 hours ago) 1:50 PM
to Clemens Backes, Jakob Kummerow, v8-re...@googlegroups.com, was...@google.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[wasm] Avoid deadlock in single-threaded streaming compilation
When two concurrent streaming compilations for the same module are
initiated in single-threaded or predictable mode, the second job must
not Wait() on the condition variable, because the first job (which
holds the cache entry and would notify) will never make progress.
Fixed by returning nullptr from MaybeGetNativeModule in these modes,
which allows the second job to proceed redundantly. De-duplication
will then be handled correctly in UpdateNativeModuleCache.
TAG=agy
R=jkum...@chromium.org
Bug: 530087580, 42201835
Change-Id: I1baf90777250433880b5e24e6032cc6e789820ea
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108382}
Files:
- M src/wasm/wasm-engine.cc
Change size: XS
Delta: 1 file changed, 6 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jakob Kummerow
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages