[turbolev] Immutable context load elimination [v8/v8 : main]

0 views
Skip to first unread message

Victor Gomes (Gerrit)

unread,
2:52 AM (9 hours ago) 2:52 AM
to Darius Mercadier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier

Victor Gomes added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Victor Gomes . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • Darius Mercadier
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If00dc4a08b5d164228803509a2efabe680fcb976
Gerrit-Change-Number: 7074771
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Oct 2025 06:52:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Darius Mercadier (Gerrit)

unread,
3:12 AM (8 hours ago) 3:12 AM
to Victor Gomes, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes

Darius Mercadier voted and added 1 comment

Votes added by Darius Mercadier

Code-Review+1

1 comment

Patchset-level comments
Darius Mercadier . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Gomes
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If00dc4a08b5d164228803509a2efabe680fcb976
Gerrit-Change-Number: 7074771
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Oct 2025 07:12:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Victor Gomes (Gerrit)

unread,
3:12 AM (8 hours ago) 3:12 AM
to Darius Mercadier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

Victor Gomes voted and added 1 comment

Votes added by Victor Gomes

Commit-Queue+2

1 comment

Patchset-level comments
Victor Gomes . resolved

Thanks!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If00dc4a08b5d164228803509a2efabe680fcb976
Gerrit-Change-Number: 7074771
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Oct 2025 07:12:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
3:14 AM (8 hours ago) 3:14 AM
to Victor Gomes, Darius Mercadier, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

V8 LUCI CQ submitted the change

Change information

Commit message:
[turbolev] Immutable context load elimination
Bug: 424157317
Change-Id: If00dc4a08b5d164228803509a2efabe680fcb976
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Commit-Queue: Victor Gomes <victo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103304}
Files:
  • M src/maglev/maglev-graph-builder.cc
  • M src/maglev/maglev-graph-optimizer.cc
  • M src/maglev/maglev-graph-optimizer.h
  • M src/maglev/maglev-ir.h
  • M src/maglev/maglev-kna-processor.h
  • M src/maglev/maglev-known-node-aspects.h
Change size: M
Delta: 6 files changed, 78 insertions(+), 15 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Darius Mercadier
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If00dc4a08b5d164228803509a2efabe680fcb976
Gerrit-Change-Number: 7074771
Gerrit-PatchSet: 2
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages