[maglev] Resume generators without the WithCatch trampoline wrapper [v8/v8 : main]

0 views

Skip to first unread message

Victor Gomes (Gerrit)

unread,

Aug 14, 2026, 9:50:30 AM (yesterday) Aug 14

to Marco Vitale, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

Attention needed from Marco Vitale

Victor Gomes voted and added 1 comment

Votes added by Victor Gomes

Auto-Submit	+1
Commit-Queue	+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Victor Gomes . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:

Marco Vitale

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Marco Vitale (Gerrit)

unread,

Aug 14, 2026, 11:25:41 AM (yesterday) Aug 14

to Victor Gomes, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

Attention needed from Victor Gomes

Marco Vitale added 2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Marco Vitale . unresolved

Could we add some (meaningful) tests here?

File src/maglev/maglev-loop-peeler.cc

Line 128, Patchset 4 (Latest): parent_clone, f.is_with_catch());

Marco Vitale . unresolved

Should we do this also in the escape analysis? (CloneBuiltinContinuationFrame)