Optimize container usage in VariableReducer. [v8/v8 : main]

0 views
Skip to first unread message

Thibaud Michaud (Gerrit)

unread,
4:38 AM (7 hours ago) 4:38 AM
to Jeffrey Yu, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jeffrey Yu

Thibaud Michaud voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jeffrey Yu
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5cd5fcb2c3219fcf1b5058d75d5b3c1088ea9cb5
Gerrit-Change-Number: 7075933
Gerrit-PatchSet: 2
Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Thibaud Michaud <thib...@chromium.org>
Gerrit-Attention: Jeffrey Yu <yu...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Oct 2025 08:37:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Darius Mercadier (Gerrit)

unread,
4:50 AM (7 hours ago) 4:50 AM
to Jeffrey Yu, Thibaud Michaud, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jeffrey Yu

Darius Mercadier voted and added 1 comment

Votes added by Darius Mercadier

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Darius Mercadier . resolved

I doubt that this makes any noticeable performance difference, and I don't particularly like the use of `.find() != .end()` over `.contains()`, but whatever, this is pretty stable code that I don't have to look at it too often, so I don't mind approving this.

Open in Gerrit

Related details

Attention is currently required from:
  • Jeffrey Yu
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5cd5fcb2c3219fcf1b5058d75d5b3c1088ea9cb5
Gerrit-Change-Number: 7075933
Gerrit-PatchSet: 2
Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Thibaud Michaud <thib...@chromium.org>
Gerrit-Attention: Jeffrey Yu <yu...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Oct 2025 08:49:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages