[debug] Add tracing for sparkplug code discarding [v8/v8 : main]

0 views
Skip to first unread message

Leszek Swirski (Gerrit)

unread,
Sep 25, 2025, 11:35:39 AM (2 days ago) Sep 25
to Patrick Thier, V8 LUCI CQ, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Patrick Thier

Leszek Swirski voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Patrick Thier
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I330d3307e5b10b3437691eb501185ce0cbe121d2
Gerrit-Change-Number: 6983090
Gerrit-PatchSet: 1
Gerrit-Owner: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Patrick Thier <pth...@chromium.org>
Gerrit-Attention: Patrick Thier <pth...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Sep 2025 15:35:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Patrick Thier (Gerrit)

unread,
Sep 26, 2025, 5:35:29 AM (yesterday) Sep 26
to Leszek Swirski, V8 LUCI CQ, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski

Patrick Thier voted and added 2 comments

Votes added by Patrick Thier

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Patrick Thier . resolved

LGTM

File src/debug/debug.cc
Line 1781, Patchset 1 (Latest): PrintF("[Sparkplug] discarding all baseline code");
Patrick Thier . unresolved
```suggestion
PrintF("[Sparkplug] discarding all baseline code\n");
```
Open in Gerrit

Related details

Attention is currently required from:
  • Leszek Swirski
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I330d3307e5b10b3437691eb501185ce0cbe121d2
Gerrit-Change-Number: 6983090
Gerrit-PatchSet: 1
Gerrit-Owner: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Patrick Thier <pth...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Sep 2025 09:35:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages