[heap] Rename PageMetadata to NormalPage [v8/v8 : main]

0 views
Skip to first unread message

Michael Lippautz (Gerrit)

unread,
Jan 9, 2026, 4:02:26 AM (yesterday) Jan 9
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, jgrube...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Dominik Inführ

Michael Lippautz voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dominik Inführ
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I938dd06f4510942f706e7a4460f6a98aa6604da2
Gerrit-Change-Number: 7417659
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Dominik Inführ <dinf...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 09:02:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dominik Inführ (Gerrit)

unread,
Jan 9, 2026, 4:58:37 AM (yesterday) Jan 9
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, jgrube...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Michael Lippautz

Dominik Inführ voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I938dd06f4510942f706e7a4460f6a98aa6604da2
Gerrit-Change-Number: 7417659
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 09:58:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
Jan 9, 2026, 5:05:09 AM (yesterday) Jan 9
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, jgrube...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org

Michael Lippautz voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I938dd06f4510942f706e7a4460f6a98aa6604da2
Gerrit-Change-Number: 7417659
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 10:05:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Jan 9, 2026, 5:07:00 AM (yesterday) Jan 9
to Michael Lippautz, Dominik Inführ, Hannes Payer, jgrube...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org

V8 LUCI CQ submitted the change

Change information

Commit message:
[heap] Rename PageMetadata to NormalPage

The term NormalPage is also used by cppgc for the same concept.
Bug: 474140208
Change-Id: I938dd06f4510942f706e7a4460f6a98aa6604da2
Reviewed-by: Dominik Inführ <dinf...@chromium.org>
Commit-Queue: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104589}
Files:
  • M BUILD.bazel
  • M BUILD.gn
  • M src/DEPS
  • M src/codegen/external-reference.h
  • M src/heap/base-page-inl.h
  • M src/heap/conservative-stack-visitor-inl.h
  • M src/heap/evacuation-verifier.cc
  • M src/heap/free-list-inl.h
  • M src/heap/free-list.cc
  • M src/heap/free-list.h
  • M src/heap/gc-tracer.cc
  • M src/heap/heap-allocator.cc
  • M src/heap/heap-controller.cc
  • M src/heap/heap-layout-tracer.cc
  • M src/heap/heap-write-barrier.cc
  • M src/heap/heap.cc
  • M src/heap/heap.h
  • M src/heap/large-spaces.cc
  • M src/heap/live-object-range-inl.h
  • M src/heap/live-object-range.h
  • M src/heap/main-allocator.cc
  • M src/heap/mark-compact-inl.h
  • M src/heap/mark-compact.cc
  • M src/heap/mark-compact.h
  • M src/heap/mark-sweep-utilities.cc
  • M src/heap/mark-sweep-utilities.h
  • M src/heap/marking-inl.h
  • M src/heap/marking.h
  • M src/heap/memory-allocator.cc
  • M src/heap/memory-allocator.h
  • M src/heap/memory-chunk.cc
  • M src/heap/memory-chunk.h
  • M src/heap/memory-pool.cc
  • M src/heap/memory-pool.h
  • M src/heap/minor-mark-sweep.cc
  • M src/heap/mutable-page.cc
  • M src/heap/new-spaces-inl.h
  • M src/heap/new-spaces.cc
  • M src/heap/new-spaces.h
  • A src/heap/normal-page-inl.h
  • R src/heap/normal-page.cc
  • R src/heap/normal-page.h
  • D src/heap/page-metadata-inl.h
  • M src/heap/paged-spaces-inl.h
  • M src/heap/paged-spaces.cc
  • M src/heap/paged-spaces.h
  • M src/heap/pretenuring-handler-inl.h
  • M src/heap/read-only-heap.h
  • M src/heap/read-only-spaces.cc
  • M src/heap/scavenger.cc
  • M src/heap/spaces-inl.h
  • M src/heap/spaces.h
  • M src/heap/sweeper.cc
  • M src/heap/sweeper.h
  • M src/roots/roots-inl.h
  • M src/snapshot/startup-deserializer.cc
  • M test/cctest/heap/heap-tester.h
  • M test/cctest/heap/heap-utils.cc
  • M test/cctest/heap/heap-utils.h
  • M test/cctest/heap/test-alloc.cc
  • M test/cctest/heap/test-array-buffer-sweeper.cc
  • M test/cctest/heap/test-compaction.cc
  • M test/cctest/heap/test-concurrent-allocation.cc
  • M test/cctest/heap/test-external-string-tracker.cc
  • M test/cctest/heap/test-heap.cc
  • M test/cctest/heap/test-mark-compact.cc
  • M test/cctest/heap/test-spaces.cc
  • M test/cctest/heap/test-weak-references.cc
  • M test/cctest/test-api.cc
  • M test/cctest/test-cpu-profiler.cc
  • M test/cctest/test-heap-profiler.cc
  • M test/cctest/test-serialize.cc
  • M test/cctest/test-shared-strings.cc
  • M test/cctest/test-unwinder-code-pages.cc
  • M test/mkgrokdump/mkgrokdump.cc
  • M test/unittests/codegen/code-pages-unittest.cc
  • M test/unittests/heap/code-range-unittest.cc
  • M test/unittests/heap/heap-unittest.cc
  • M test/unittests/heap/heap-utils.cc
  • M test/unittests/heap/heap-utils.h
  • M test/unittests/heap/inner-pointer-resolution-unittest.cc
  • M test/unittests/heap/page-promotion-unittest.cc
  • M test/unittests/heap/pool-unittest.cc
  • M test/unittests/heap/slot-set-unittest.cc
  • M test/unittests/heap/spaces-unittest.cc
  • M test/unittests/objects/weakmaps-unittest.cc
  • M test/unittests/objects/weaksets-unittest.cc
  • M test/unittests/utils/allocation-unittest.cc
Change size: XL
Delta: 88 files changed, 740 insertions(+), 759 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Dominik Inführ
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I938dd06f4510942f706e7a4460f6a98aa6604da2
Gerrit-Change-Number: 7417659
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages