[compiler] Pass context to PropagateException for Fast API calls [v8/v8 : main]
0 views
Skip to first unread message
Dominik Inführ (Gerrit)
6:25 AM (5 hours ago) 6:25 AM
to Darius Mercadier, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Darius Mercadier
Dominik Inführ added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
6:28 AM (5 hours ago) 6:28 AM
to Dominik Inführ, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
7:36 AM (4 hours ago) 7:36 AM
to Darius Mercadier, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Darius Mercadier
Dominik Inführ added 2 comments![]( "Open in Gerrit")
Patchset-level comments
LGTM, but could you add a test maybe?
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
7:49 AM (4 hours ago) 7:49 AM
to Dominik Inführ, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
Dominik Inführ . resolved
added the test, PTALA
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
8:17 AM (3 hours ago) 8:17 AM
to Darius Mercadier, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
8:24 AM (3 hours ago) 8:24 AM
to Dominik Inführ, Darius Mercadier, dmercadi...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[compiler] Pass context to PropagateException for Fast API calls
Fast API calls were using null as context when invoking
Runtime_PropagateException() in the exception case. This is different
to CEntry and CallApiCallback which both pass the correct context as
argument in this case.
Calling PropagateException goes through CEntry. CEntry stores the
context argument into IsolateFieldId::kContext.
Fast API calls still continue to clear the IsolateFieldId::kContext
field in the success (non-exception) case in debug builds.
Bug: 473236688
Change-Id: I3dcd51474339424875e5a2766638395c8b40f9bc
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104671}
Files:
- M src/compiler/turboshaft/fast-api-call-lowering-reducer.h
- A test/mjsunit/compiler/fast-api-calls-exception.js
- M test/mjsunit/mjsunit.status
Change size: S
Delta: 3 files changed, 30 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darius Mercadier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages