[d8] Fix contradictory values for sandbox corruption flags [v8/v8 : main]
0 views
Skip to first unread message
Clemens Backes (Gerrit)
11:30 AM (10 hours ago) 11:30 AM
to v8-s...@luci-project-accounts.iam.gserviceaccount.com, Jakob Kummerow, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow
Clemens Backes added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Jakob Kummerow
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
12:08 PM (9 hours ago) 12:08 PM
to Clemens Backes, Jakob Kummerow, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Clemens Backes
Jakob Kummerow voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Clemens Backes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
1:47 PM (8 hours ago) 1:47 PM
to Jakob Kummerow, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Clemens Backes voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
1:49 PM (8 hours ago) 1:49 PM
to Clemens Backes, Jakob Kummerow, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[d8] Fix contradictory values for sandbox corruption flags
When both --trace-memory-corruption-via-watchpoints and
--memory-corruption-via-watchpoints are provided, d8 would
FATAL because trace_memory_corruption_via_watchpoints is a
DisallowReassignment flag and it was assigned twice.
This CL wraps the assignment in a check to ensure it is only
assigned when actually enabled.
R=jkum...@chromium.org
Change-Id: I6f06129d5fb2fa965d25ca8f39e5a1f24d9ffabf
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108381}
Files:
- M src/d8/d8.cc
Change size: XS
Delta: 1 file changed, 3 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jakob Kummerow
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages