[maglev] Compute value ranges for Int32ModulusWithOverflow [v8/v8 : main]

0 views
Skip to first unread message

Victor Gomes (Gerrit)

unread,
Aug 14, 2026, 9:18:29 AM (yesterday) Aug 14
to Marco Vitale, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Marco Vitale

Victor Gomes voted and added 1 comment

Votes added by Victor Gomes

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Victor Gomes . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • Marco Vitale
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If6a21784a36b8114bf03a2b9f334f22a8d6a9b42
Gerrit-Change-Number: 8253438
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Marco Vitale <mrc...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Marco Vitale <mrc...@chromium.org>
Gerrit-Comment-Date: Fri, 14 Aug 2026 13:18:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Marco Vitale (Gerrit)

unread,
Aug 14, 2026, 10:36:51 AM (yesterday) Aug 14
to Victor Gomes, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes

Marco Vitale voted and added 1 comment

Votes added by Marco Vitale

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Marco Vitale . resolved

Nice, ty!

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Gomes
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If6a21784a36b8114bf03a2b9f334f22a8d6a9b42
Gerrit-Change-Number: 8253438
Gerrit-PatchSet: 2
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Marco Vitale <mrc...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Fri, 14 Aug 2026 14:36:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Aug 14, 2026, 10:39:14 AM (yesterday) Aug 14
to Victor Gomes, Marco Vitale, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
[maglev] Compute value ranges for Int32ModulusWithOverflow

The result of x % d is bounded by the divisor magnitude and the dividend
sign. Knowing the range lets loops bounded by a modulus fold the
Smi-size check on their counter phi and downgrade the increment to a
non-overflow-checked one.
Bug: 42204525
Change-Id: If6a21784a36b8114bf03a2b9f334f22a8d6a9b42
Auto-Submit: Victor Gomes <victo...@chromium.org>
Commit-Queue: Marco Vitale <mrc...@chromium.org>
Reviewed-by: Marco Vitale <mrc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#109261}
Files:
  • M src/maglev/maglev-range-analysis.h
  • M src/maglev/maglev-range.h
  • A test/mjsunit/maglev/int32-mod-range.js
Change size: M
Delta: 3 files changed, 103 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Marco Vitale
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If6a21784a36b8114bf03a2b9f334f22a8d6a9b42
Gerrit-Change-Number: 8253438
Gerrit-PatchSet: 3
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Marco Vitale <mrc...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages