[riscv] Drop support for 32-bit entries in constant pools [v8/v8 : main]
0 views
Skip to first unread message
Florian Loitsch (Gerrit)
4:25 AM (10 hours ago) 4:25 AM
to Kasper Lund, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Kasper Lund
Florian Loitsch voted and added 2 comments![]( "Open in Gerrit")
Votes added by Florian Loitsch
| Code-Review | +1 |
2 comments
Patchset-level comments
File src/codegen/riscv/constant-pool-riscv.cc
Line 246, Patchset 2:
// auipc x0, x0, #words ;; Pool marker, encodes size in words.Florian Loitsch . unresolved
```suggestion
// auipc x0, #words ;; Pool marker, encodes size in words.
```
Related details
Attention is currently required from:
- Kasper Lund
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kasper Lund (Gerrit)
4:27 AM (10 hours ago) 4:27 AM
to Florian Loitsch, V8 LUCI CQ, v8-re...@googlegroups.com
Kasper Lund added 1 comment![]( "Open in Gerrit")
File src/codegen/riscv/constant-pool-riscv.cc
Line 246, Patchset 2:
// auipc x0, x0, #words ;; Pool marker, encodes size in words.Florian Loitsch . resolved
```suggestion
// auipc x0, #words ;; Pool marker, encodes size in words.
```
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kasper Lund (Gerrit)
4:42 AM (9 hours ago) 4:42 AM
to Florian Loitsch, V8 LUCI CQ, v8-re...@googlegroups.com
Kasper Lund voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
4:48 AM (9 hours ago) 4:48 AM
to Kasper Lund, Florian Loitsch, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[riscv] Drop support for 32-bit entries in constant pools
Change-Id: I0609b467e04156bfa4b126edb16f6776f4eb7684
Reviewed-by: Florian Loitsch <floi...@rivosinc.com>
Commit-Queue: Kasper Lund <kas...@rivosinc.com>
Cr-Commit-Position: refs/heads/main@{#102781}
Files:
- M src/codegen/riscv/assembler-riscv.h
- M src/codegen/riscv/constant-pool-riscv.cc
- M src/codegen/riscv/constant-pool-riscv.h
Change size: L
Delta: 3 files changed, 131 insertions(+), 215 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Florian Loitsch
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages