[intl] Throw error while Date value is too large for ICU [v8/v8 : main]

0 views
Skip to first unread message

Olivier Flückiger (Gerrit)

unread,
4:15 AM (7 hours ago) 4:15 AM
to Frank Tang, Philip Jägenstedt, Rezvan Mahdavi Hezaveh, Manish Goregaokar, Shane Carr, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Frank Tang, Philip Jägenstedt and Rezvan Mahdavi Hezaveh

Olivier Flückiger voted and added 1 comment

Votes added by Olivier Flückiger

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Olivier Flückiger . resolved

lgtm, thanks

Open in Gerrit

Related details

Attention is currently required from:
  • Frank Tang
  • Philip Jägenstedt
  • Rezvan Mahdavi Hezaveh
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id7334213fd59c75215604857c8c0b279ceff179e
Gerrit-Change-Number: 7077217
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Tang <ft...@chromium.org>
Gerrit-Reviewer: Frank Tang <ft...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Reviewer: Rezvan Mahdavi Hezaveh <rez...@google.com>
Gerrit-CC: Manish Goregaokar <manis...@google.com>
Gerrit-CC: Shane Carr <sf...@google.com>
Gerrit-Attention: Rezvan Mahdavi Hezaveh <rez...@google.com>
Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Attention: Frank Tang <ft...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Oct 2025 08:15:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Philip Jägenstedt (Gerrit)

unread,
5:00 AM (6 hours ago) 5:00 AM
to Frank Tang, Olivier Flückiger, Rezvan Mahdavi Hezaveh, Manish Goregaokar, Shane Carr, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Frank Tang and Rezvan Mahdavi Hezaveh

Philip Jägenstedt added 1 comment

Patchset-level comments
Philip Jägenstedt . resolved

Thanks for the fix!

Open in Gerrit

Related details

Attention is currently required from:
  • Frank Tang
  • Rezvan Mahdavi Hezaveh
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id7334213fd59c75215604857c8c0b279ceff179e
Gerrit-Change-Number: 7077217
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Tang <ft...@chromium.org>
Gerrit-Reviewer: Frank Tang <ft...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Reviewer: Rezvan Mahdavi Hezaveh <rez...@google.com>
Gerrit-CC: Manish Goregaokar <manis...@google.com>
Gerrit-CC: Shane Carr <sf...@google.com>
Gerrit-Attention: Rezvan Mahdavi Hezaveh <rez...@google.com>
Gerrit-Attention: Frank Tang <ft...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Oct 2025 09:00:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages