[sandbox] Make CSA_SBXCHECK always a CSA_CHECK [v8/v8 : main]

0 views
Skip to first unread message

Samuel Groß (Gerrit)

unread,
Nov 17, 2025, 12:57:14 PM (2 days ago) Nov 17
to Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Leszek Swirski

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Leszek Swirski
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I8be06495f50ddcc1720a68ac5596ff9652f2b8b5
Gerrit-Change-Number: 7162414
Gerrit-PatchSet: 1
Gerrit-Owner: Samuel Groß <sa...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Samuel Groß <sa...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Mon, 17 Nov 2025 17:57:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Leszek Swirski (Gerrit)

unread,
Nov 18, 2025, 8:00:46 AM (yesterday) Nov 18
to Samuel Groß, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Samuel Groß

Leszek Swirski voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Samuel Groß
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I8be06495f50ddcc1720a68ac5596ff9652f2b8b5
Gerrit-Change-Number: 7162414
Gerrit-PatchSet: 1
Gerrit-Owner: Samuel Groß <sa...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Samuel Groß <sa...@chromium.org>
Gerrit-Attention: Samuel Groß <sa...@chromium.org>
Gerrit-Comment-Date: Tue, 18 Nov 2025 13:00:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Samuel Groß (Gerrit)

unread,
Nov 18, 2025, 8:03:20 AM (yesterday) Nov 18
to Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com

Samuel Groß voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I8be06495f50ddcc1720a68ac5596ff9652f2b8b5
Gerrit-Change-Number: 7162414
Gerrit-PatchSet: 1
Gerrit-Owner: Samuel Groß <sa...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Samuel Groß <sa...@chromium.org>
Gerrit-Comment-Date: Tue, 18 Nov 2025 13:03:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Nov 18, 2025, 8:05:00 AM (yesterday) Nov 18
to Samuel Groß, Leszek Swirski, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[sandbox] Make CSA_SBXCHECK always a CSA_CHECK

In crrev.com/c/6862992 we changed SBXCHECK to always be a CHECK, even if
the sandbox is not active. This CL does the same for the CSA variant.
Change-Id: I8be06495f50ddcc1720a68ac5596ff9652f2b8b5
Reviewed-by: Leszek Swirski <les...@chromium.org>
Commit-Queue: Samuel Groß <sa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103786}
Files:
  • M src/codegen/define-code-stub-assembler-macros.inc
  • M src/interpreter/interpreter-generator.cc
Change size: XS
Delta: 2 files changed, 1 insertion(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Leszek Swirski
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I8be06495f50ddcc1720a68ac5596ff9652f2b8b5
Gerrit-Change-Number: 7162414
Gerrit-PatchSet: 2
Gerrit-Owner: Samuel Groß <sa...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Samuel Groß <sa...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages