[cppgc] Release virtual memory in ReleasePooledPages [v8/v8 : main]
0 views
Skip to first unread message
Michael Lippautz (Gerrit)
6:35 AM (3 hours ago) 6:35 AM
to Anton Bikineev, AyeAye, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Anton Bikineev
Michael Lippautz added 1 comment![]( "Open in Gerrit")
File src/heap/cppgc/page-memory.cc
Line 171, Patchset 3 (Parent):
ASAN_UNPOISON_MEMORY_REGION(base, size);Michael Lippautz . unresolved
Are we loosing any poisoning here? Or I guess we depend on poisoning from the BPA?
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bikineev (Gerrit)
6:51 AM (2 hours ago) 6:51 AM
to Michael Lippautz, AyeAye, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Anton Bikineev added 1 comment![]( "Open in Gerrit")
File src/heap/cppgc/page-memory.cc
Line 171, Patchset 3 (Parent):
ASAN_UNPOISON_MEMORY_REGION(base, size);Michael Lippautz . resolved
Are we loosing any poisoning here? Or I guess we depend on poisoning from the BPA?
Anton Bikineev
No, ~PageMemoryRegion() calls FreeMemoryRegion() which unpoisons the region
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
6:55 AM (2 hours ago) 6:55 AM
to Anton Bikineev, AyeAye, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Anton Bikineev
Michael Lippautz voted and added 2 comments![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
2 comments
Patchset-level comments
Commit Message
Line 16, Patchset 3 (Latest):
Michael Lippautz . unresolved
Lets add that this also releases address space on 32-bit systems.
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bikineev (Gerrit)
7:24 AM (2 hours ago) 7:24 AM
to Michael Lippautz, AyeAye, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Anton Bikineev voted and added 2 comments![]( "Open in Gerrit")
Votes added by Anton Bikineev
| Commit-Queue | +2 |
2 comments
Patchset-level comments
Commit Message
Lets add that this also releases address space on 32-bit systems.
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
7:26 AM (2 hours ago) 7:26 AM
to Anton Bikineev, Michael Lippautz, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[cppgc] Release virtual memory in ReleasePooledPages
The page pool used to only decommit pages but keep the virtual memory
reservation. This change ensures that virtual memory is released back
to the allocator (e.g. the BoundedPageAllocator in the cage) when
ReleasePooledPages() is called. For non-caged configurations (e.g.
32-bit) this releases the virtual memory and as such mitigates OOMs.
This also simplifies NormalPageMemoryPool by removing the unused
is_decommitted and is_discarded flags.
Change-Id: I0645a9d4467b28c9ead0b5acf089759d93316160
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Anton Bikineev <biki...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105411}
Files:
- M src/heap/cppgc/page-memory.cc
- M src/heap/cppgc/page-memory.h
- M test/unittests/heap/cppgc/page-memory-unittest.cc
Change size: M
Delta: 3 files changed, 29 insertions(+), 65 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages