[Wasm interpreter] Fix handling of globals storage [v8/v8 : main]
0 views
Skip to first unread message
Paolo Severini (Gerrit)
Mar 10, 2026, 12:08:26 PMMar 10
to V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Attention needed from Paolo Severini
Message from Paolo Severini![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention is currently required from:
- Paolo Severini
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
Mar 11, 2026, 2:22:44 PMMar 11
to Paolo Severini, Jakob Kummerow, Gyuyoung Kim, Daniel Lehmann, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Attention needed from Daniel Lehmann and Paolo Severini
Jakob Kummerow voted and added 2 comments![]( "Open in Gerrit")
Votes added by Jakob Kummerow
| Code-Review | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Jakob Kummerow . resolved
LGTM with a comment. (Didn't look at `src/wasm/interpreter/` as usual.)
File test/filecheck/filecheck.status
Line 6, Patchset 6 (Latest):
['variant == jitless', {Jakob Kummerow . unresolved
Please move this somewhere further down, so the `ALWAYS` block remains first. Perhaps around line 32, after the `variant in (jitless, ...` block?
Related details
Attention is currently required from:
- Daniel Lehmann
- Paolo Severini
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paolo Severini (Gerrit)
Mar 12, 2026, 11:33:46 AMMar 12
to Jakob Kummerow, Gyuyoung Kim, Daniel Lehmann, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Attention needed from Daniel Lehmann and Jakob Kummerow
Paolo Severini voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paolo Severini
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 8 (Latest):
Paolo Severini . resolved
Hi Jakob, could you take another look? Many thanks!
Related details
Attention is currently required from:
- Daniel Lehmann
- Jakob Kummerow
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
Mar 12, 2026, 12:22:41 PMMar 12
to Paolo Severini, Jakob Kummerow, Gyuyoung Kim, Daniel Lehmann, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Attention needed from Daniel Lehmann and Paolo Severini
Jakob Kummerow voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Daniel Lehmann
- Paolo Severini
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
Mar 12, 2026, 12:23:02 PMMar 12
to Paolo Severini, Jakob Kummerow, Gyuyoung Kim, Daniel Lehmann, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Attention needed from Daniel Lehmann and Paolo Severini
Jakob Kummerow added 1 comment![]( "Open in Gerrit")
File test/filecheck/filecheck.status
Please move this somewhere further down, so the `ALWAYS` block remains first. Perhaps around line 32, after the `variant in (jitless, ...` block?
Jakob Kummerow
Marking as done.
Related details
Attention is currently required from:
- Daniel Lehmann
- Paolo Severini
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paolo Severini (Gerrit)
Mar 12, 2026, 12:30:37 PMMar 12
to Jakob Kummerow, Gyuyoung Kim, Daniel Lehmann, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Attention needed from Daniel Lehmann
Paolo Severini voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Daniel Lehmann
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Mar 12, 2026, 12:32:26 PMMar 12
to Paolo Severini, Jakob Kummerow, Gyuyoung Kim, Daniel Lehmann, v8-re...@googlegroups.com, was...@google.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Wasm interpreter] Fix handling of globals storage
This fixes the Wasm interpreter build and all the tests after a
recent change to the handling of globals' storage.
The fix avoids caching the location of the globals because they can
be moved by the GC. Instead, the location is looked up on demand
when needed.
Also fixes an unrelated issue after a recent change to SafepointEntry.
Also fixes the build after a revert made to Managed<T>::raw(), which
does not return a std::shared_ptr<T> anymore.
Bug: 491318550
Change-Id: Ib87912d83f3a1af45bc713a3ef51fda56a173224
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Paolo Severini <paol...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#105772}
Files:
- M src/execution/frames.cc
- M src/wasm/interpreter/wasm-interpreter-objects.cc
- M src/wasm/interpreter/wasm-interpreter-objects.h
- M src/wasm/interpreter/wasm-interpreter-runtime-inl.h
- M src/wasm/interpreter/wasm-interpreter-runtime.cc
- M src/wasm/interpreter/wasm-interpreter-runtime.h
- M test/filecheck/filecheck.status
- M test/fuzzer/wasm/interpreter/interpreter-fuzzer-common.cc
- M test/message/message.status
- M test/mjsunit/mjsunit.status
- M test/wasm-spec-tests/wasm-spec-tests.status
Change size: M
Delta: 11 files changed, 58 insertions(+), 35 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jakob Kummerow
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paolo Severini (Gerrit)
Mar 12, 2026, 12:34:00 PMMar 12
to V8 LUCI CQ, Jakob Kummerow, Gyuyoung Kim, Daniel Lehmann, v8-re...@googlegroups.com, was...@google.com
Paolo Severini added 1 comment![]( "Open in Gerrit")
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages