[wasm] Promote a DCHECK to a CHECK [v8/v8 : main]
0 views
Skip to first unread message
Clemens Backes (Gerrit)
Jan 8, 2026, 8:43:20 AM (22 hours ago) Jan 8
to V8 LUCI CQ, Jakob Kummerow, v8-re...@googlegroups.com, was...@google.com
Attention needed from Jakob Kummerow
Clemens Backes added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Clemens Backes . resolved
We have some really old crash there; this is to test the hypothesis that this crashes because there's no entry in the map for that pointer.
Related details
Attention is currently required from:
- Jakob Kummerow
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
Jan 8, 2026, 9:00:25 AM (21 hours ago) Jan 8
to Clemens Backes, Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Attention needed from Clemens Backes
Jakob Kummerow voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Clemens Backes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Jan 8, 2026, 9:05:57 AM (21 hours ago) Jan 8
to Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Clemens Backes voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 8, 2026, 9:07:24 AM (21 hours ago) Jan 8
to Clemens Backes, Jakob Kummerow, v8-re...@googlegroups.com, was...@google.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[wasm] Promote a DCHECK to a CHECK
To figure out if this is really the reason for some crashes in the wild,
see referenced bug.
R=jkum...@chromium.org
Bug: 466449860
Change-Id: I6a158acc045497bf773d5394b1b0477c938869e4
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104560}
Files:
- M src/wasm/wasm-engine.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jakob Kummerow
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages