[sandbox] Ensure Isolate::PushStackTraceAndDie is not re-entrant [v8/v8 : main]

0 views
Skip to first unread message

Arash Kazemi (Gerrit)

unread,
11:52 AM (8 hours ago) 11:52 AM
to Clemens Backes, v8-re...@googlegroups.com
Attention needed from Clemens Backes

Arash Kazemi voted and added 1 comment

Votes added by Arash Kazemi

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Arash Kazemi . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Clemens Backes
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I41872e5eabfcfae27dcf71a310ea11d1652e63fc
Gerrit-Change-Number: 7799877
Gerrit-PatchSet: 1
Gerrit-Owner: Arash Kazemi <ara...@chromium.org>
Gerrit-Reviewer: Arash Kazemi <ara...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Attention: Clemens Backes <clem...@chromium.org>
Gerrit-Comment-Date: Tue, 28 Apr 2026 15:52:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Clemens Backes (Gerrit)

unread,
11:55 AM (8 hours ago) 11:55 AM
to Arash Kazemi, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Arash Kazemi

Clemens Backes voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Arash Kazemi
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I41872e5eabfcfae27dcf71a310ea11d1652e63fc
    Gerrit-Change-Number: 7799877
    Gerrit-PatchSet: 1
    Gerrit-Owner: Arash Kazemi <ara...@chromium.org>
    Gerrit-Reviewer: Arash Kazemi <ara...@chromium.org>
    Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
    Gerrit-Attention: Arash Kazemi <ara...@chromium.org>
    Gerrit-Comment-Date: Tue, 28 Apr 2026 15:55:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Arash Kazemi (Gerrit)

    unread,
    1:08 PM (7 hours ago) 1:08 PM
    to Igor Sheludko, Clemens Backes, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
    Attention needed from Igor Sheludko

    Arash Kazemi voted and added 1 comment

    Votes added by Arash Kazemi

    Auto-Submit+1

    1 comment

    Patchset-level comments
    Arash Kazemi . resolved

    +Igor for OWNERS

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Igor Sheludko
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I41872e5eabfcfae27dcf71a310ea11d1652e63fc
    Gerrit-Change-Number: 7799877
    Gerrit-PatchSet: 1
    Gerrit-Owner: Arash Kazemi <ara...@chromium.org>
    Gerrit-Reviewer: Arash Kazemi <ara...@chromium.org>
    Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
    Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
    Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
    Gerrit-Comment-Date: Tue, 28 Apr 2026 17:08:35 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Igor Sheludko (Gerrit)

    unread,
    1:30 PM (6 hours ago) 1:30 PM
    to Arash Kazemi, Clemens Backes, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
    Attention needed from Arash Kazemi

    Igor Sheludko voted and added 1 comment

    Votes added by Igor Sheludko

    Code-Review+1
    Commit-Queue+2

    1 comment

    Patchset-level comments
    Igor Sheludko . resolved

    lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Arash Kazemi
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I41872e5eabfcfae27dcf71a310ea11d1652e63fc
    Gerrit-Change-Number: 7799877
    Gerrit-PatchSet: 1
    Gerrit-Owner: Arash Kazemi <ara...@chromium.org>
    Gerrit-Reviewer: Arash Kazemi <ara...@chromium.org>
    Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
    Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
    Gerrit-Attention: Arash Kazemi <ara...@chromium.org>
    Gerrit-Comment-Date: Tue, 28 Apr 2026 17:30:01 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

    unread,
    2:06 PM (6 hours ago) 2:06 PM
    to Arash Kazemi, Igor Sheludko, Clemens Backes, v8-re...@googlegroups.com

    v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change

    Change information

    Commit message:
    [sandbox] Ensure Isolate::PushStackTraceAndDie is not re-entrant
    Fixed: 506463838
    Change-Id: I41872e5eabfcfae27dcf71a310ea11d1652e63fc
    Auto-Submit: Arash Kazemi <ara...@chromium.org>
    Commit-Queue: Igor Sheludko <ish...@chromium.org>
    Reviewed-by: Clemens Backes <clem...@chromium.org>
    Reviewed-by: Igor Sheludko <ish...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#106901}
    Files:
    • M src/execution/isolate.cc
    Change size: XS
    Delta: 1 file changed, 3 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Clemens Backes, +1 by Igor Sheludko
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I41872e5eabfcfae27dcf71a310ea11d1652e63fc
    Gerrit-Change-Number: 7799877
    Gerrit-PatchSet: 2
    Gerrit-Owner: Arash Kazemi <ara...@chromium.org>
    Gerrit-Reviewer: Arash Kazemi <ara...@chromium.org>
    Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
    Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages