[wasm][fuzzer] A few minor cleanups [v8/v8 : main]
Clemens Backes (Gerrit)
Clemens Backes added 1 comment![]( "Open in Gerrit")
A few random things I saw while investigating https://crbug.com/472729752; PTAL.
Related details
- Matthias Liedtke
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthias Liedtke (Gerrit)
Matthias Liedtke voted and added 2 comments![]( "Open in Gerrit")
Votes added by Matthias Liedtke
| Code-Review | +1 |
2 comments
LGTM
size_t split_index = types.size() / 2;Amazing engineering. 😄
Note that I seem to have copied the previous thing over to two new places, `EmitCallAndReturnValues` and `EmitCallAndReturnValues` have the same modulo thing to create two subvectors from one input vector of types...
Could you update those places as well? (See `uint32_t returns_split`)
Related details
- Clemens Backes
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Clemens Backes added 1 comment![]( "Open in Gerrit")
size_t split_index = types.size() / 2;Amazing engineering. 😄
Note that I seem to have copied the previous thing over to two new places, `EmitCallAndReturnValues` and `EmitCallAndReturnValues` have the same modulo thing to create two subvectors from one input vector of types...
Could you update those places as well? (See `uint32_t returns_split`)
Aren't those places where we really want to split randomly?
This place here actually wants to split in two roughly equally sized halves, which is a different goal.
Related details
- Matthias Liedtke
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthias Liedtke (Gerrit)
Matthias Liedtke added 1 comment![]( "Open in Gerrit")
size_t split_index = types.size() / 2;Clemens BackesAmazing engineering. 😄
Note that I seem to have copied the previous thing over to two new places, `EmitCallAndReturnValues` and `EmitCallAndReturnValues` have the same modulo thing to create two subvectors from one input vector of types...
Could you update those places as well? (See `uint32_t returns_split`)
Aren't those places where we really want to split randomly?
This place here actually wants to split in two roughly equally sized halves, which is a different goal.
Ah sorry, yes, I searched for the pattern and found it in other places, you're right, this is unrelated. I should've checked more carefully.
Related details
- Clemens Backes
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Clemens Backes voted Commit-Queue+2![]( "Open in Gerrit")
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[wasm][fuzzer] A few minor cleanups
- use type `int` more consistently,
- split types in half when saying so, and
- fix a probability and the comment to match reality.
R=mlie...@chromium.org
- M src/wasm/fuzzing/random-module-generation.cc
Code-Review: +1 by Matthias Liedtke
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |