[wasm] Fix DCHECK in streaming compilation without code section [v8/v8 : main]

0 views
Skip to first unread message

Clemens Backes (Gerrit)

unread,
5:49 AM (16 hours ago) 5:49 AM
to android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Jakob Kummerow, v8-re...@googlegroups.com, was...@google.com
Attention needed from Jakob Kummerow

Clemens Backes added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Clemens Backes . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Jakob Kummerow
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5ce551048d67fcf1833b4b3df4da60f87a5a3ca9
Gerrit-Change-Number: 8030140
Gerrit-PatchSet: 2
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Attention: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Jul 2026 09:49:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jakob Kummerow (Gerrit)

unread,
10:00 AM (11 hours ago) 10:00 AM
to Clemens Backes, Jakob Kummerow, android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com, was...@google.com
Attention needed from Clemens Backes

Jakob Kummerow voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Clemens Backes
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5ce551048d67fcf1833b4b3df4da60f87a5a3ca9
Gerrit-Change-Number: 8030140
Gerrit-PatchSet: 2
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Attention: Clemens Backes <clem...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Jul 2026 14:00:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Clemens Backes (Gerrit)

unread,
10:16 AM (11 hours ago) 10:16 AM
to Jakob Kummerow, android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com, was...@google.com

Clemens Backes voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5ce551048d67fcf1833b4b3df4da60f87a5a3ca9
Gerrit-Change-Number: 8030140
Gerrit-PatchSet: 2
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Jul 2026 14:16:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
10:18 AM (11 hours ago) 10:18 AM
to Clemens Backes, Jakob Kummerow, android-bu...@system.gserviceaccount.com, v8-re...@googlegroups.com, was...@google.com

v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
[wasm] Fix DCHECK in streaming compilation without code section

Streaming compilation of a module without a code section (e.g. only
imports) was hitting a DCHECK in single-threaded or jitless mode
because compilation was never initialized. This happened because
ProcessCodeSectionHeader was bypassed.

Fixed by calling InitializeCompilationProgress explicitly when creating
the NativeModule for such modules in OnFinishedStream.

TAG=agy
R=jkum...@chromium.org
Bug: 529862624
Change-Id: I5ce551048d67fcf1833b4b3df4da60f87a5a3ca9
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108368}
Files:
  • M src/wasm/module-compiler.cc
  • A test/mjsunit/wasm/regress-streaming-empty-single-threaded.js
Change size: S
Delta: 2 files changed, 19 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Jakob Kummerow
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5ce551048d67fcf1833b4b3df4da60f87a5a3ca9
Gerrit-Change-Number: 8030140
Gerrit-PatchSet: 3
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages