[sandbox] Add missing exports for [Dis]allowSandboxAccess [v8/v8 : main]
0 views
Skip to first unread message
Maksim Ivanov (Gerrit)
Jan 9, 2026, 7:08:15 AM (yesterday) Jan 9
to Michael Lippautz, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Maksim Ivanov voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Jan 9, 2026, 7:21:28 AM (yesterday) Jan 9
to Maksim Ivanov, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Maksim Ivanov
Michael Lippautz voted![]( "Open in Gerrit")
Attention is currently required from:
- Maksim Ivanov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 9, 2026, 7:40:58 AM (yesterday) Jan 9
to Maksim Ivanov, Michael Lippautz, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[sandbox] Add missing exports for [Dis]allowSandboxAccess
Fix linking errors in the "DEBUG + V8_ENABLE_SANDBOX_HARDWARE_SUPPORT +
is_component_build" configuration:
ld.lld: error: undefined symbol: v8::internal::DisallowSandboxAccess::DisallowSandboxAccess()
>>> referenced by bytecode-expectations-printer.cc
>>> obj/test/unittests/generate-bytecode-expectations/bytecode-expectations-printer.o:(v8::internal::ExternalPointerTable::Get(unsigned int, v8::internal::TagRange<v8::internal::ExternalPointerTag>) const)
>>> referenced by bytecode-expectations-printer.cc
>>> obj/test/unittests/generate-bytecode-expectations/bytecode-expectations-printer.o:(v8::internal::SharedFunctionInfo::GetActiveBytecodeArray(v8::internal::Isolate*) const)
>>> referenced by bytecode-expectations-printer.cc
>>> obj/test/unittests/generate-bytecode-expectations/bytecode-expectations-printer.o:(v8::internal::SharedFunctionInfo::GetActiveBytecodeArray(v8::internal::Isolate*) const)
Bug: 350324877
Change-Id: I4ae3103212526e9a8c3665d80b766b88a2bb72b8
Commit-Queue: Michael Lippautz <mlip...@chromium.org>
Auto-Submit: Maksim Ivanov <em...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Maksim Ivanov <em...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104593}
Files:
- M src/sandbox/hardware-support.h
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages