[regexp] Revamp the heuristics that pick search strategy [v8/v8 : main]
0 views
Skip to first unread message
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 9, 2026, 8:21:18 PM (3 days ago) Jan 9
to Erik Corry, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Erik Corry
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m4-mini-perf/jetstream2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12b662e3b10000
Related details
Attention is currently required from:
- Erik Corry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 9, 2026, 8:32:48 PM (3 days ago) Jan 9
to Erik Corry, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Erik Corry
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job linux-perf/jetstream2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12d5bc51b10000
Related details
Attention is currently required from:
- Erik Corry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 10, 2026, 5:07:02 AM (3 days ago) Jan 10
to Erik Corry, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Erik Corry
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m4-mini-perf/jetstream2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/16bf5b97b10000
Related details
Attention is currently required from:
- Erik Corry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 10, 2026, 5:40:20 AM (3 days ago) Jan 10
to Erik Corry, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Erik Corry
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job linux-perf/jetstream2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/174c2cafb10000
Related details
Attention is currently required from:
- Erik Corry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 10, 2026, 11:45:10 AM (2 days ago) Jan 10
to Erik Corry, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Erik Corry
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m4-mini-perf/jetstream2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1433b0eeb10000
Related details
Attention is currently required from:
- Erik Corry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 10, 2026, 12:10:47 PM (2 days ago) Jan 10
to Erik Corry, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Erik Corry
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job linux-perf/jetstream2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/17ac9a87b10000
Related details
Attention is currently required from:
- Erik Corry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Erik Corry (Gerrit)
Jan 10, 2026, 2:29:51 PM (2 days ago) Jan 10
to Jakob Linke, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Erik Corry and Jakob Linke
Erik Corry voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Erik Corry
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 10, 2026, 3:28:59 PM (2 days ago) Jan 10
to Erik Corry, Jakob Linke, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Erik Corry and Jakob Linke
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
😿 Job mac-m4-mini-perf/jetstream3.crossbench failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1462e900710000
Related details
Attention is currently required from:
- Erik Corry
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 10, 2026, 4:12:00 PM (2 days ago) Jan 10
to Erik Corry, Jakob Linke, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Erik Corry and Jakob Linke
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
😿 Job linux-perf/jetstream3.crossbench failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/10b6050fb10000
Related details
Attention is currently required from:
- Erik Corry
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 11, 2026, 9:17:12 AM (yesterday) Jan 11
to Erik Corry, Jakob Linke, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Erik Corry and Jakob Linke
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m4-mini-perf/jetstream2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1496f919b10000
Related details
Attention is currently required from:
- Erik Corry
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 11, 2026, 10:38:41 AM (yesterday) Jan 11
to Erik Corry, Jakob Linke, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Erik Corry and Jakob Linke
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
😿 Job linux-perf/jetstream3.crossbench failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1585acd7b10000
Related details
Attention is currently required from:
- Erik Corry
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
7:00 AM (15 hours ago) 7:00 AM
to Erik Corry, Jakob Linke, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Erik Corry and Jakob Linke
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job linux-perf/jetstream2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/135334c3b10000
Related details
Attention is currently required from:
- Erik Corry
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
8:07 AM (14 hours ago) 8:07 AM
to Erik Corry, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Erik Corry
Jakob Linke voted and added 4 comments![]( "Open in Gerrit")
Votes added by Jakob Linke
| Code-Review | +1 |
4 comments
File src/regexp/regexp-compiler.cc
Line 2813, Patchset 7:
if (points > biggest_points) {Jakob Linke . unresolved
So frequency >= kSize is implicitly treated as "not found" here and above? Worth a comment in both spots.
Line 2818, Patchset 7:
mask &= ~(char_one ^ char_two); // Mask out the bit where they differ.Jakob Linke . unresolved
```suggestion
mask &= ~(char_one ^ char_two); // Mask out the bits where they differ.
```
Line 2928, Patchset 7 (Parent):
if (map->map_count() == 0) {Jakob Linke . unresolved
Is this case preserved?
Line 2974, Patchset 7 (Parent):
// TODO(pthier): Add vectorized version. At that point we will wantJakob Linke . unresolved
Let's keep the todo. (Coincidentally I was just thinking about addressing it.)
Related details
Attention is currently required from:
- Erik Corry
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Erik Corry (Gerrit)
9:04 AM (13 hours ago) 9:04 AM
to Jakob Linke, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Erik Corry added 2 comments![]( "Open in Gerrit")
File src/regexp/regexp-compiler.cc
Line 2813, Patchset 7:
if (points > biggest_points) {Jakob Linke . resolved
So frequency >= kSize is implicitly treated as "not found" here and above? Worth a comment in both spots.
Erik Corry
Done
Line 2818, Patchset 7:
mask &= ~(char_one ^ char_two); // Mask out the bit where they differ.Jakob Linke . resolved
```suggestion
mask &= ~(char_one ^ char_two); // Mask out the bits where they differ.
```
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Erik Corry (Gerrit)
9:19 AM (13 hours ago) 9:19 AM
to Jakob Linke, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Erik Corry and Jakob Linke
Erik Corry voted and added 2 comments![]( "Open in Gerrit")
Votes added by Erik Corry
| Commit-Queue | +1 |
2 comments
File src/regexp/regexp-compiler.cc
Line 2928, Patchset 7 (Parent):
if (map->map_count() == 0) {Jakob Linke . unresolved
Is this case preserved?
Erik Corry
Reinstated.
Line 2974, Patchset 7 (Parent):
// TODO(pthier): Add vectorized version. At that point we will wantJakob Linke . unresolved
Let's keep the todo. (Coincidentally I was just thinking about addressing it.)
Erik Corry
Added this comment.
// This means use SIMD for skip-until-bit-in-table. TODO: If we write
// SIMD macro assembler instructions for mask-compare we will want to
// rename this and evaluate separately when to trigger the SIMD variant
// of the mask-compare.
bool use_simd = masm->SkipUntilBitInTableUseSimd(1) &&
Related details
Attention is currently required from:
- Erik Corry
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages