[*lev] Fix empty type coming from GetSmiValue [v8/v8 : main]
0 views
Skip to first unread message
Marja Hölttä (Gerrit)
Jul 24, 2026, 7:10:24 AM (22 hours ago) Jul 24
to Victor Gomes, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Marja Hölttä added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Jul 24, 2026, 7:18:39 AM (22 hours ago) Jul 24
to Marja Hölttä, Victor Gomes, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Marja Hölttä and Victor Gomes
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Marja Hölttä
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marja Hölttä (Gerrit)
Jul 24, 2026, 7:20:52 AM (22 hours ago) Jul 24
to Darius Mercadier, Victor Gomes, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Marja Hölttä voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 24, 2026, 7:23:01 AM (22 hours ago) Jul 24
to Marja Hölttä, Darius Mercadier, Victor Gomes, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[*lev] Fix empty type coming from GetSmiValue
Checking for conflicting type information in GetSmiValue allows us to
deopt earlier, instead of generating nodes like
CheckedSmiTagHoleyFloat64<something which is surely not a smi>.
Bug: 534277460
Change-Id: Ia9c2118a64c3e6a16b3b093736c1e61bb74c8cc7
Fixed: 537884726
Commit-Queue: Marja Hölttä <ma...@chromium.org>
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108863}
Files:
- M src/maglev/maglev-reducer-inl.h
- A test/mjsunit/maglev/regress-537884726.js
Change size: S
Delta: 2 files changed, 26 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darius Mercadier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages