Enable VTune JIT profiling support for wasm-c-api with bazel [v8/v8 : main]
Rahul S Chaphalkar (Gerrit)
Attention is currently required from: Rahul S Chaphalkar.
Rahul S Chaphalkar uploaded patch set #2 to this change.
Enable VTune JIT profiling support for wasm-c-api with bazel
This change allows bazel build to enable vtune jit support via flag
`v8_enable_vtunejit` set to true, similar to GN.
Enables appropriate libraries for wee8 when flag is true.
Support enabled in wasm/c-api.cc and wee8 library so that embedders
which use wasm-c-api can use vtune support.
Bug: N/A
Test: bazel build --//:v8_enable_vtunejit=true wee8
https://bugs.chromium.org/p/v8/issues/detail?id=14056&q=vtune%20bazel&can=2
Change-Id: I0cdf3f98f33fb6eb9876854c64a1ab122a45e81d
---
M BUILD.bazel
M WORKSPACE
A bazel/BUILD.ittapi
M src/wasm/c-api.cc
4 files changed, 60 insertions(+), 2 deletions(-)
To view, visit change 4641270. To unsubscribe, or for help writing mail filters, visit settings.
Michael Achenbach (Gerrit)
Attention is currently required from: Rahul S Chaphalkar.
1 comment:
Patchset:
I've added your account to project-v8-tryjob-access - tryjobs and dry run should work now.
To view, visit change 4641270. To unsubscribe, or for help writing mail filters, visit settings.
Jakob Kummerow (Gerrit)
Attention is currently required from: Rahul S Chaphalkar, Victor Gomes.
Jakob Kummerow would like Victor Gomes to review this change authored by Rahul S Chaphalkar.
Enable VTune JIT profiling support for wasm-c-api with bazel
This change allows bazel build to enable vtune jit support via flag
`v8_enable_vtunejit` set to true, similar to GN.
Enables appropriate libraries for wee8 when flag is true.
Support enabled in wasm/c-api.cc and wee8 library so that embedders
which use wasm-c-api can use vtune support.
Bug: N/A
Test: bazel build --//:v8_enable_vtunejit=true wee8
https://bugs.chromium.org/p/v8/issues/detail?id=14056&q=vtune%20bazel&can=2
Change-Id: I0cdf3f98f33fb6eb9876854c64a1ab122a45e81d
---
M BUILD.bazel
M WORKSPACE
A bazel/BUILD.ittapi
M src/wasm/c-api.cc
4 files changed, 60 insertions(+), 2 deletions(-)
Jakob Kummerow (Gerrit)
Attention is currently required from: Rahul S Chaphalkar, Victor Gomes.
Patch set 2:Code-Review +1Commit-Queue +1
1 comment:
Patchset:
src/wasm/ LGTM.
+Victor for Bazel changes.
To view, visit change 4641270. To unsubscribe, or for help writing mail filters, visit settings.
Victor Gomes (Gerrit)
Attention is currently required from: Jakob Kummerow, Rahul S Chaphalkar.
Patch set 2:Code-Review +1
3 comments:
Patchset:
LGTM % formatting both BUILD.ittapi and BUILD.bazel
We also need to update bazel in the bots.
File WORKSPACE:
Patch Set #2, Line 61:
add_prefix = "third_party/ittapi",I guess the bot is using an old version of bazel that does not support add_prefix.
File bazel/BUILD.ittapi:
Nit: use bazel formatter:
https://github.com/bazelbuild/buildtools/blob/master/buildifier/README.md
To view, visit change 4641270. To unsubscribe, or for help writing mail filters, visit settings.
Victor Gomes (Gerrit)
Attention is currently required from: Jakob Kummerow, Rahul S Chaphalkar.
Patch Set #2, Line 61:
add_prefix = "third_party/ittapi",I guess the bot is using an old version of bazel that does not support add_prefix.
We are going to land a bazel update in the bots, so that we can use the {add_prefix} here: https://chromium-review.googlesource.com/c/v8/v8/+/4648351
To view, visit change 4641270. To unsubscribe, or for help writing mail filters, visit settings.
Rahul S Chaphalkar (Gerrit)
Attention is currently required from: Jakob Kummerow, Rahul S Chaphalkar, Victor Gomes.
Patch set 3:Commit-Queue +2
V8 LUCI CQ (Gerrit)
V8 LUCI CQ submitted this change.
Enable VTune JIT profiling support for wasm-c-api with bazel
This change allows bazel build to enable vtune jit support via flag
`v8_enable_vtunejit` set to true, similar to GN.
Enables appropriate libraries for wee8 when flag is true.
Support enabled in wasm/c-api.cc and wee8 library so that embedders
which use wasm-c-api can use vtune support.
Bug: N/A
Test: bazel build --//:v8_enable_vtunejit=true wee8
https: //bugs.chromium.org/p/v8/issues/detail?id=14056&q=vtune%20bazel&can=2
Change-Id: I0cdf3f98f33fb6eb9876854c64a1ab122a45e81d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4641270
Reviewed-by: Victor Gomes <victo...@chromium.org>
Commit-Queue: Rahul S Chaphalkar <rahul.s.c...@intel.com>
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#88516}
---
M BUILD.bazel
M WORKSPACE
A bazel/BUILD.ittapi
M src/wasm/c-api.cc
4 files changed, 62 insertions(+), 2 deletions(-)
Rezvan Mahdavi Hezaveh (Gerrit)
Rezvan Mahdavi Hezaveh has created a revert of this change.
To view, visit change 4641270. To unsubscribe, or for help writing mail filters, visit settings.