[runtime] Resurrect add operation in xorshift128+ implementation [v8/v8 : main]
0 views
Skip to first unread message
Igor Sheludko (Gerrit)
Nov 18, 2025, 12:10:43 PM (20 hours ago) Nov 18
to Leszek Swirski, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Igor Sheludko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Nov 18, 2025, 12:13:21 PM (20 hours ago) Nov 18
to V8 LUCI CQ, Leszek Swirski, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Igor Sheludko removed a vote from this change![]( "Open in Gerrit")
Removed Auto-Submit+1 by Igor Sheludko <ish...@chromium.org>
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Nov 18, 2025, 12:29:11 PM (20 hours ago) Nov 18
to Igor Sheludko, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Igor Sheludko
Leszek Swirski voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Nov 18, 2025, 12:34:05 PM (20 hours ago) Nov 18
to Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com
Igor Sheludko voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Nov 18, 2025, 12:48:19 PM (20 hours ago) Nov 18
to Igor Sheludko, Leszek Swirski, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[runtime] Resurrect add operation in xorshift128+ implementation
... which was accidentally removed in https://crrev.com/c/1238551.
Bug: 456384547
Change-Id: I5640493f7b5376edca476698195d4b823657414f
Reviewed-by: Leszek Swirski <les...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103799}
Files:
- M src/base/utils/random-number-generator.cc
- M src/base/utils/random-number-generator.h
- M src/numbers/math-random.cc
Change size: S
Delta: 3 files changed, 12 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Leszek Swirski
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages