[maglev] Remove the old VirtualObject special cases [v8/v8 : main]
0 views
Skip to first unread message
Jakob Linke (Gerrit)
1:57 AM (10 hours ago) 1:57 AM
to Victor Gomes, V8 LUCI CQ, AyeAye, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
4:07 AM (8 hours ago) 4:07 AM
to Jakob Linke, V8 LUCI CQ, AyeAye, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Jakob Linke
Victor Gomes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Victor Gomes
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
6:57 AM (5 hours ago) 6:57 AM
to Victor Gomes, V8 LUCI CQ, AyeAye, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Jakob Linke voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
6:59 AM (5 hours ago) 6:59 AM
to Jakob Linke, Victor Gomes, AyeAye, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[maglev] Remove the old VirtualObject special cases
.. now that all types are ported to the new layout.
* Remove type_. All objects now use the same slots layout. Types are
further distinguished within ObjectLayout.
* Remove field_count(), it is now the same as slot_count().
* Remove the union which used to house the different layout variants.
* Change slots_ to be a base::Vector (including debug range checks).
Change-Id: I507b43ed8b27e1bdc575583c67e2c629982d6558
Reviewed-by: Victor Gomes <victo...@chromium.org>
Commit-Queue: Jakob Linke <jgr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102790}
Files:
- M src/compiler/turboshaft/turbolev-graph-builder.cc
- M src/maglev/maglev-code-generator.cc
- M src/maglev/maglev-graph-builder.cc
- M src/maglev/maglev-ir.cc
- M src/maglev/maglev-ir.h
Change size: L
Delta: 5 files changed, 88 insertions(+), 305 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Victor Gomes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages