Use string_view instead of string to avoid string copies. [v8/v8 : main]
0 views
Skip to first unread message
Thibaud Michaud (Gerrit)
Jan 9, 2026, 5:51:00 AM (yesterday) Jan 9
to Jeffrey Yu, V8 LUCI CQ, dmercadi...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Jeffrey Yu
Thibaud Michaud voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jeffrey Yu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Jan 9, 2026, 5:51:51 AM (yesterday) Jan 9
to Jeffrey Yu, Thibaud Michaud, V8 LUCI CQ, dmercadi...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Jeffrey Yu
Darius Mercadier voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jeffrey Yu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeffrey Yu (Gerrit)
Jan 9, 2026, 4:06:06 PM (yesterday) Jan 9
to Darius Mercadier, Thibaud Michaud, V8 LUCI CQ, dmercadi...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Jeffrey Yu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 9, 2026, 5:06:03 PM (23 hours ago) Jan 9
to Jeffrey Yu, Darius Mercadier, Thibaud Michaud, dmercadi...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Use string_view instead of string to avoid string copies.
string_view won't make a string copy when using `.substr()`. `.length()`
and `.size()` on string_view also avoids a branch (since `std::string`
has to check if it's using small string optimization).
This change will only make a string copy on an unlikely branch path
(because string_view doesn't provide a `.c_str()` method to return a
null-terminated C-style string).
Change-Id: I81ca8a0eac0c7a29f047357840f73c2f76d55ee1
Reviewed-by: Thibaud Michaud <thib...@chromium.org>
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Commit-Queue: Jeffrey Yu <yu...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104613}
Files:
- M src/objects/intl-objects.cc
Change size: S
Delta: 1 file changed, 7 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thibaud Michaud, +1 by Darius Mercadier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages