[sandbox] Simplify JSDispatchTable read only allocation [v8/v8 : main]
0 views
Skip to first unread message
Omer Katz (Gerrit)
Feb 2, 2026, 8:19:26 PM (2 days ago) Feb 2
to Michael Lippautz, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Omer Katz added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File src/execution/isolate.cc
Line 8009, Patchset 5 (Parent):
base::LazyMutex read_only_dispatch_entries_mutex_ = LAZY_MUTEX_INITIALIZER;Omer Katz . unresolved
This mutex should no longer be needed since each isolate owns their own read only space now.
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
2:00 AM (2 hours ago) 2:00 AM
to Michael Lippautz, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Omer Katz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Omer Katz . resolved
ping
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
2:51 AM (1 hour ago) 2:51 AM
to Omer Katz, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Omer Katz
Michael Lippautz added 1 comment![]( "Open in Gerrit")
File src/sandbox/js-dispatch-table.cc
Line 59, Patchset 5 (Parent):
DCHECK_EQ(IndexToHandle(idx), IndexToHandle(HandleToIndex(first) + i));
}
CHECK_EQ(IndexToHandle(idx), GetStaticHandleForReadOnlySegmentEntry(i));Michael Lippautz . unresolved
Don't we rely on this somewhere? I guess the regular allocation method work but we should still make sure we preserve the invariant?
Related details
Attention is currently required from:
- Omer Katz
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages