[maglev] Use holey_float64 alternative for HoleyFloat64 representation [v8/v8 : main]

0 views
Skip to first unread message

Nico Hartmann (Gerrit)

unread,
Nov 18, 2025, 11:14:16 AM (21 hours ago) Nov 18
to Victor Gomes, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes

Nico Hartmann voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Victor Gomes
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I272f83682f84e35e4e36de88c8ff7a0793b27610
Gerrit-Change-Number: 7168623
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Tue, 18 Nov 2025 16:14:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Victor Gomes (Gerrit)

unread,
Nov 18, 2025, 11:24:00 AM (21 hours ago) Nov 18
to Nico Hartmann, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Nico Hartmann

Victor Gomes voted and added 1 comment

Votes added by Victor Gomes

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Victor Gomes . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Nico Hartmann
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I272f83682f84e35e4e36de88c8ff7a0793b27610
Gerrit-Change-Number: 7168623
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Comment-Date: Tue, 18 Nov 2025 16:23:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Nov 18, 2025, 11:55:08 AM (21 hours ago) Nov 18
to Nico Hartmann, Victor Gomes, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

V8 LUCI CQ submitted the change

Change information

Commit message:
[maglev] Use holey_float64 alternative for HoleyFloat64 representation
Bug: 459335522
Change-Id: I272f83682f84e35e4e36de88c8ff7a0793b27610
Commit-Queue: Nico Hartmann <nicoha...@chromium.org>
Auto-Submit: Nico Hartmann <nicoha...@chromium.org>
Reviewed-by: Victor Gomes <victo...@chromium.org>
Commit-Queue: Victor Gomes <victo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103797}
Files:
  • M src/maglev/maglev-known-node-aspects.h
  • M test/mjsunit/regress/regress-459335522.js
Change size: M
Delta: 2 files changed, 29 insertions(+), 33 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Victor Gomes
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I272f83682f84e35e4e36de88c8ff7a0793b27610
Gerrit-Change-Number: 7168623
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages