[wasm] Disable memory protection with mprotect for lazy compilation [v8/v8 : main]
Andreas Haas (Gerrit)
Attention is currently required from: Stephen Röttger.
1 comment:
Patchset:
PTAL
To view, visit change 3627596. To unsubscribe, or for help writing mail filters, visit settings.
Stephen Röttger (Gerrit)
Attention is currently required from: Andreas Haas.
1 comment:
Patchset:
LGTM! (I don't have vote permissions though)
To view, visit change 3627596. To unsubscribe, or for help writing mail filters, visit settings.
Andreas Haas (Gerrit)
Attention is currently required from: Clemens Backes.
1 comment:
Patchset:
Can you also please take a look, Clemens?
To view, visit change 3627596. To unsubscribe, or for help writing mail filters, visit settings.
Clemens Backes (Gerrit)
File src/flags/flag-definitions.h:
Patch Set #1, Line 1121:
DEFINE_NEG_IMPLICATION(wasm_lazy_compilation, wasm_write_protect_code_memory)Can we make this a weak implication, so we can still overwrite it explicitly via passing --wasm-write-protect-code-memory?
To view, visit change 3627596. To unsubscribe, or for help writing mail filters, visit settings.
Andreas Haas (Gerrit)
Attention is currently required from: Clemens Backes.
1 comment:
File src/flags/flag-definitions.h:
Patch Set #1, Line 1121:
DEFINE_NEG_IMPLICATION(wasm_lazy_compilation, wasm_write_protect_code_memory)
Can we make this a weak implication, so we can still overwrite it explicitly via passing --wasm-writ […]
Done
To view, visit change 3627596. To unsubscribe, or for help writing mail filters, visit settings.
Clemens Backes (Gerrit)
Attention is currently required from: Andreas Haas.
Patch set 2:Code-Review +1
1 comment:
Patchset:
Thanks, LGTM.
To view, visit change 3627596. To unsubscribe, or for help writing mail filters, visit settings.
Andreas Haas (Gerrit)
Attention is currently required from: Andreas Haas.
Patch set 2:Commit-Queue +2
V8 LUCI CQ (Gerrit)
V8 LUCI CQ submitted this change.
[wasm] Disable memory protection with mprotect for lazy compilation
The write protection of code memory with mprotect is too expensive for
lazy compilation. As the usefulness of this memory protection is
limited anyways, this CL disables the memory protection in case lazy
compilation is enabled.
Bug: v8:12852
Change-Id: I4c56d4021a7b594e24a4d3d28a130a309c56de38
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3627596
Reviewed-by: Clemens Backes <clem...@chromium.org>
Commit-Queue: Andreas Haas <ah...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80377}
---
M src/flags/flag-definitions.h
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/src/flags/flag-definitions.h b/src/flags/flag-definitions.h
index a8c59eb..cf559b8 100644
--- a/src/flags/flag-definitions.h
+++ b/src/flags/flag-definitions.h
@@ -20,6 +20,9 @@
#define DEFINE_WEAK_IMPLICATION(whenflag, thenflag) \
DEFINE_WEAK_VALUE_IMPLICATION(whenflag, thenflag, true)
+#define DEFINE_WEAK_NEG_IMPLICATION(whenflag, thenflag) \
+ DEFINE_WEAK_VALUE_IMPLICATION(whenflag, thenflag, false)
+
#define DEFINE_NEG_IMPLICATION(whenflag, thenflag) \
DEFINE_VALUE_IMPLICATION(whenflag, thenflag, false)
@@ -524,7 +527,7 @@
#if V8_SHORT_BUILTIN_CALLS
DEFINE_WEAK_IMPLICATION(future, short_builtin_calls)
#endif
-DEFINE_WEAK_VALUE_IMPLICATION(future, write_protect_code_memory, false)
+DEFINE_WEAK_NEG_IMPLICATION(future, write_protect_code_memory)
DEFINE_WEAK_IMPLICATION(future, compact_maps)
DEFINE_BOOL_READONLY(dict_property_const_tracking,
@@ -1120,6 +1123,9 @@
DEFINE_IMPLICATION(validate_asm, asm_wasm_lazy_compilation)
DEFINE_BOOL(wasm_lazy_compilation, false,
"enable lazy compilation for all wasm modules")
+// Write protect code causes too much overhead for lazy compilation.
+DEFINE_WEAK_NEG_IMPLICATION(wasm_lazy_compilation,
+ wasm_write_protect_code_memory)
DEFINE_DEBUG_BOOL(trace_wasm_lazy_compilation, false,
"trace lazy compilation of wasm functions")
DEFINE_BOOL(wasm_lazy_validation, false,
@@ -2264,6 +2270,7 @@
#undef DEFINE_FLOAT
#undef DEFINE_IMPLICATION
#undef DEFINE_WEAK_IMPLICATION
+#undef DEFINE_WEAK_NEG_IMPLICATION
#undef DEFINE_NEG_IMPLICATION
#undef DEFINE_NEG_VALUE_IMPLICATION
#undef DEFINE_VALUE_IMPLICATION
To view, visit change 3627596. To unsubscribe, or for help writing mail filters, visit settings.
Zone Realties Nagpur (Gerrit)
1 comment:
Patchset:
Zone Realties Nagpur
To view, visit change 3627596. To unsubscribe, or for help writing mail filters, visit settings.