Revert "[regexp] Ship RegExp match indices" [v8/v8 : master]

Michael Achenbach (Gerrit)

unread,

Feb 9, 2021, 3:47:44 AM2/9/21

to Shu-yu Guo, Jakob Gruber, Michael Hablich, v8-re...@googlegroups.com

Attention is currently required from: Shu-yu Guo, Jakob Gruber.

Michael Achenbach would like Commit Bot, Shu-yu Guo and Jakob Gruber to review this change.

Revert "[regexp] Ship RegExp match indices"

This reverts commit 72464122bda24e8712b7600e7d250e600dde97c1.

Reason for revert:
https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/32046

Original change's description:
> [regexp] Ship RegExp match indices
>
> I2S:
> https://groups.google.com/a/chromium.org/g/blink-dev/c/RR_dw_ZXtT0/m/xtgu5jjyAQAJ
>
> Bug: v8:9548
> Change-Id: I8ccf2f4c38f9b9204ae47162303f21d2d44498e8
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2682508
> Commit-Queue: Jakob Gruber <jgr...@chromium.org>
> Auto-Submit: Shu-yu Guo <s...@chromium.org>
> Reviewed-by: Jakob Gruber <jgr...@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#72571}

TBR=jgr...@chromium.org,s...@chromium.org

Change-Id: I1173389082928aa5c9895ca4fb360c7ab8ec073b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:9548
---
M src/flags/flag-definitions.h
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/flags/flag-definitions.h b/src/flags/flag-definitions.h
index 2156afa..cc2184e 100644
--- a/src/flags/flag-definitions.h
+++ b/src/flags/flag-definitions.h
@@ -260,9 +260,10 @@
 #endif
 
 // Features that are complete (but still behind --harmony/es-staging flag).
-#define HARMONY_STAGED_BASE(V)                          \
-  V(harmony_top_level_await, "harmony top level await") \
-  V(harmony_relative_indexing_methods, "harmony relative indexing methods")
+#define HARMONY_STAGED_BASE(V)                                              \
+  V(harmony_top_level_await, "harmony top level await")                     \
+  V(harmony_relative_indexing_methods, "harmony relative indexing methods") \
+  V(harmony_regexp_match_indices, "harmony regexp match indices")
 
 #ifdef V8_INTL_SUPPORT
 #define HARMONY_STAGED(V)               \
@@ -280,8 +281,7 @@
   V(harmony_weak_refs, "harmony weak references")                     \
   V(harmony_string_replaceall, "harmony String.prototype.replaceAll") \
   V(harmony_logical_assignment, "harmony logical assignment")         \
-  V(harmony_atomics_waitasync, "harmony Atomics.waitAsync")           \
-  V(harmony_regexp_match_indices, "harmony regexp match indices")
+  V(harmony_atomics_waitasync, "harmony Atomics.waitAsync")
 
 #ifdef V8_INTL_SUPPORT
 #define HARMONY_SHIPPING(V) HARMONY_SHIPPING_BASE(V)

To view, visit change 2681943. To unsubscribe, or for help writing mail filters, visit settings.

Michael Achenbach (Gerrit)

unread,

Feb 9, 2021, 3:47:51 AM2/9/21

to Shu-yu Guo, Jakob Gruber, Michael Hablich, v8-re...@googlegroups.com

Attention is currently required from: Shu-yu Guo, Jakob Gruber.

Patch set 1:Code-Review +1Commit-Queue +2

View Change

To view, visit change 2681943. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Feb 9, 2021, 3:48:05 AM2/9/21

to Michael Achenbach, Shu-yu Guo, Jakob Gruber, Michael Hablich, v8-re...@googlegroups.com

Commit Bot submitted this change.

View Change

Approvals:
  Michael Achenbach: Looks good to me; Commit

Revert "[regexp] Ship RegExp match indices"

This reverts commit 72464122bda24e8712b7600e7d250e600dde97c1.

Reason for revert:
https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/32046

Original change's description:
> [regexp] Ship RegExp match indices
>
> I2S:
> https://groups.google.com/a/chromium.org/g/blink-dev/c/RR_dw_ZXtT0/m/xtgu5jjyAQAJ
>
> Bug: v8:9548
> Change-Id: I8ccf2f4c38f9b9204ae47162303f21d2d44498e8
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2682508
> Commit-Queue: Jakob Gruber <jgr...@chromium.org>
> Auto-Submit: Shu-yu Guo <s...@chromium.org>
> Reviewed-by: Jakob Gruber <jgr...@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#72571}

TBR=jgr...@chromium.org,s...@chromium.org

Change-Id: I1173389082928aa5c9895ca4fb360c7ab8ec073b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:9548

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2681943
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Commit-Queue: Michael Achenbach <mache...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72576}

To view, visit change 2681943. To unsubscribe, or for help writing mail filters, visit settings.

Shu-yu Guo (Gerrit)

unread,

Feb 9, 2021, 6:42:01 PM2/9/21

to Michael Achenbach, Jakob Gruber, Michael Hablich, v8-re...@googlegroups.com

Shu-yu Guo has created a revert of this change.

View Change

To view, visit change 2681943. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward