Darius Mercadier (Gerrit)

unread,

Mar 10, 2026, 9:53:24 AMMar 10

to Victor Gomes, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com

Attention needed from Victor Gomes

Darius Mercadier voted and added 1 comment

Votes added by Darius Mercadier

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Darius Mercadier . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

Victor Gomes

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Victor Gomes (Gerrit)

unread,

Mar 10, 2026, 9:55:22 AMMar 10

to Darius Mercadier, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com

Attention needed from Darius Mercadier

Victor Gomes voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Darius Mercadier

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

V8 LUCI CQ (Gerrit)

unread,

Mar 10, 2026, 9:57:00 AMMar 10

to Darius Mercadier, Victor Gomes, dmercadi...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:

[turbolev] Fix lowering of ConvertInt32ToHeapNumber

Fixed: 490450922

Change-Id: I5312dbf018b6e99deac9d6428344e7d00db4866a

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7652218

Commit-Queue: Victor Gomes <victo...@chromium.org>

Auto-Submit: Darius Mercadier <dmerc...@chromium.org>

Reviewed-by: Victor Gomes <victo...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#105705}

Files:

M src/compiler/turboshaft/machine-lowering-reducer-inl.h
A test/mjsunit/turbolev/regress-490450922-1.js
A test/mjsunit/turbolev/regress-490450922-2.js
A test/mjsunit/turbolev/regress-490450922-3.js

Change size: M

Delta: 4 files changed, 96 insertions(+), 4 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Victor Gomes

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[turbolev] Fix lowering of ConvertInt32ToHeapNumber [v8/v8 : main]

Darius Mercadier (Gerrit)

Darius Mercadier voted and added 1 comment

Votes added by Darius Mercadier

1 comment

Related details

Victor Gomes (Gerrit)

Victor Gomes voted

Related details

V8 LUCI CQ (Gerrit)

V8 LUCI CQ submitted the change

Change information