[wasm][shared] Handle shared Wasm objects in SharedValueBarrier [v8/v8 : main]
0 views
Skip to first unread message
Manos Koukoutos (Gerrit)
Mar 10, 2026, 8:29:36 AMMar 10
to Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow
Manos Koukoutos added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Jakob Kummerow
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
Mar 10, 2026, 3:13:17 PMMar 10
to Manos Koukoutos, Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Manos Koukoutos
Jakob Kummerow added 1 comment![]( "Open in Gerrit")
File src/codegen/code-stub-assembler.cc
Line 20199, Patchset 2 (Latest):
GotoIf(InstanceTypeEqual(value_instance_type, WASM_ARRAY_TYPE),Jakob Kummerow . unresolved
Let's do it right while we're at it, and use a single range-based check. See `IsJSFunctionInstanceType` for inspiration; we should have a similar `IsWasmObjectInstanceType` predicate.
Related details
Attention is currently required from:
- Manos Koukoutos
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Manos Koukoutos (Gerrit)
Mar 11, 2026, 2:08:39 AMMar 11
to Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow
Manos Koukoutos added 1 comment![]( "Open in Gerrit")
File src/codegen/code-stub-assembler.cc
Line 20199, Patchset 2:
GotoIf(InstanceTypeEqual(value_instance_type, WASM_ARRAY_TYPE),Jakob Kummerow . resolved
Let's do it right while we're at it, and use a single range-based check. See `IsJSFunctionInstanceType` for inspiration; we should have a similar `IsWasmObjectInstanceType` predicate.
Attention is currently required from:
- Jakob Kummerow
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
Mar 11, 2026, 8:49:40 AMMar 11
to Manos Koukoutos, Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Manos Koukoutos
Jakob Kummerow voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Manos Koukoutos
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Manos Koukoutos (Gerrit)
Mar 12, 2026, 5:57:57 AMMar 12
to Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com
Manos Koukoutos voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Mar 12, 2026, 7:43:24 AMMar 12
to Manos Koukoutos, Jakob Kummerow, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[wasm][shared] Handle shared Wasm objects in SharedValueBarrier
Bug: 490877756, 42204563
Change-Id: Ib7c5d5ac0d870b5753c7e0abfa25983378bd5b96
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Manos Koukoutos <mano...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105759}
Files:
- M src/codegen/code-stub-assembler.cc
- A test/mjsunit/regress/wasm/regress-490877756.js
Change size: S
Delta: 2 files changed, 38 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jakob Kummerow
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages