[turbofan][maglev] Improve inlining tracing [v8/v8 : main]
0 views
Skip to first unread message
Darius Mercadier (Gerrit)
Jul 18, 2025, 10:17:50 AMJul 18
to Victor Gomes, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Jul 18, 2025, 10:23:17 AMJul 18
to Darius Mercadier, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier
Victor Gomes added 4 comments![]( "Open in Gerrit")
File src/compiler/turboshaft/turbolev-graph-builder.cc
Line 6427, Patchset 1 (Latest):
if (V8_UNLIKELY(data->info()->trace_turbo_graph())) {
PrintMaglevGraph(*data, maglev_graph, "After inlining");
}Victor Gomes . unresolved
Inside Inlining we already print the graphs, but via --print-maglev-graphs. Should we do || trace_turbo_graph there?
File src/maglev/maglev-inlining.cc
Line 116, Patchset 1 (Latest):
if (V8_UNLIKELY(v8_flags.print_maglev_graphs && is_tracing_enabled())) {Victor Gomes . unresolved
Here
Line 128, Patchset 1 (Latest):
if (V8_UNLIKELY(v8_flags.print_maglev_graphs && is_tracing_enabled())) {Victor Gomes . unresolved
Here
Line 151, Patchset 1 (Latest):
if (V8_UNLIKELY(v8_flags.print_maglev_graphs && is_tracing_enabled())) {Victor Gomes . unresolved
and here
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Jul 18, 2025, 10:23:35 AMJul 18
to Darius Mercadier, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier
Victor Gomes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Victor Gomes
| Code-Review | +1 |
1 comment
Patchset-level comments
Victor Gomes . resolved
LGTM
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Jul 18, 2025, 10:27:56 AMJul 18
to Victor Gomes, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Darius Mercadier added 5 comments![]( "Open in Gerrit")
Patchset-level comments
Darius Mercadier . resolved
Meh, tests fail because they check for the exact output. I don't have time to fix them, so that'll wait until I'm back :D
File src/compiler/turboshaft/turbolev-graph-builder.cc
Line 6427, Patchset 1 (Latest):
if (V8_UNLIKELY(data->info()->trace_turbo_graph())) {
PrintMaglevGraph(*data, maglev_graph, "After inlining");
}Victor Gomes . unresolved
Inside Inlining we already print the graphs, but via --print-maglev-graphs. Should we do || trace_turbo_graph there?
Darius Mercadier
Ah yea, we should teach Maglev that the Turbofan flags control Turbolev tracing rather than the Maglev flags. But it's late, so I'll do this in September I guess :)
File src/maglev/maglev-inlining.cc
Line 116, Patchset 1 (Latest):
if (V8_UNLIKELY(v8_flags.print_maglev_graphs && is_tracing_enabled())) {Victor Gomes . resolved
Darius MercadierHere
Acknowledged
Line 128, Patchset 1 (Latest):
if (V8_UNLIKELY(v8_flags.print_maglev_graphs && is_tracing_enabled())) {Victor Gomes . resolved
Darius MercadierHere
Acknowledged
Line 151, Patchset 1 (Latest):
if (V8_UNLIKELY(v8_flags.print_maglev_graphs && is_tracing_enabled())) {Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Jul 18, 2025, 10:29:48 AMJul 18
to Darius Mercadier, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier
Victor Gomes added 1 comment![]( "Open in Gerrit")
File src/compiler/turboshaft/turbolev-graph-builder.cc
Line 6427, Patchset 1 (Latest):
if (V8_UNLIKELY(data->info()->trace_turbo_graph())) {
PrintMaglevGraph(*data, maglev_graph, "After inlining");
}Victor Gomes . resolved
Darius MercadierInside Inlining we already print the graphs, but via --print-maglev-graphs. Should we do || trace_turbo_graph there?
Ah yea, we should teach Maglev that the Turbofan flags control Turbolev tracing rather than the Maglev flags. But it's late, so I'll do this in September I guess :)
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Sep 4, 2025, 3:35:10 AM (3 days ago) Sep 4
to Victor Gomes, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Auto-Submit | +1 |
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Sep 4, 2025, 5:41:36 AM (3 days ago) Sep 4
to Darius Mercadier, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier
Victor Gomes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Victor Gomes
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Sep 4, 2025, 5:42:19 AM (3 days ago) Sep 4
to Victor Gomes, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Darius Mercadier voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Sep 4, 2025, 5:45:15 AM (3 days ago) Sep 4
to Darius Mercadier, Victor Gomes, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[turbofan][maglev] Improve inlining tracing
Bug: 42204525
Change-Id: I6bd8f0125b6ff7d41d71940445fa7a1aa1bfcc70
Commit-Queue: Darius Mercadier <dmerc...@chromium.org>
Auto-Submit: Darius Mercadier <dmerc...@chromium.org>
Reviewed-by: Victor Gomes <victo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102235}
Files:
- M src/compiler/js-inlining-heuristic.cc
- M src/maglev/maglev-inlining.cc
- M src/maglev/maglev-phi-representation-selector.cc
- M test/message/wasm-inlining-into-js.out
Change size: S
Delta: 4 files changed, 24 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Victor Gomes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages