[superspread] Various fixes when accessing elements [v8/v8 : main]
0 views
Skip to first unread message
Olivier Flückiger (Gerrit)
Mar 9, 2026, 4:25:51 PMMar 9
to V8 LUCI CQ, Toon Verwaest, v8-re...@googlegroups.com
Attention needed from Toon Verwaest
Olivier Flückiger voted and added 2 comments![]( "Open in Gerrit")
Votes added by Olivier Flückiger
| Auto-Submit | +1 |
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Olivier Flückiger . resolved
ptal again. this changed quite a bit. after fixing the tests I had to basically fix everything...
File src/builtins/builtins-array.cc
Line 559, Patchset 2:
return isolate->factory()->undefined_value();Toon Verwaest . resolved
Olivier FlückigerIf we need to handle holes we probably need to handle what's behind the hole?
As discussed offline that part was actually correct as we only end up here if the array is "clean". Everything else was broken though 😭
Related details
Attention is currently required from:
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Toon Verwaest (Gerrit)
Mar 10, 2026, 12:29:44 PMMar 10
to Olivier Flückiger, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Olivier Flückiger
Toon Verwaest voted![]( "Open in Gerrit")
Attention is currently required from:
- Olivier Flückiger
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Mar 10, 2026, 12:31:23 PMMar 10
to Olivier Flückiger, Toon Verwaest, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[superspread] Various fixes when accessing elements
Fixes when accessing the arguments:
* off-by-one access of the arglist
* reverseing of non-arglist arguments
* converting holes
We also fix the tests which previously didn't surface errors and
ran the same tests multiple times. This allows us to enable the test
in debug mode again.
Fixed: 488404930
Change-Id: I224b48a3c623749e267586b3603aaf5df786bbed
Commit-Queue: Toon Verwaest <verw...@chromium.org>
Auto-Submit: Olivier Flückiger <ol...@chromium.org>
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105708}
Files:
- M src/builtins/arm64/builtins-arm64.cc
- M src/builtins/builtins-array.cc
- M src/builtins/superspread.h
- M src/builtins/x64/builtins-x64.cc
- M test/mjsunit/arbitrary-length-varargs.js
- M test/mjsunit/mjsunit.status
Change size: M
Delta: 6 files changed, 40 insertions(+), 24 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Toon Verwaest
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages