[baseline] Make ForOfNextBaseline write the registers [v8/v8 : main]
0 views
Skip to first unread message
Leszek Swirski (Gerrit)
Sep 25, 2025, 11:24:40 AM (yesterday) Sep 25
to Rezvan Mahdavi Hezaveh, Nico Hartmann, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Nico Hartmann and Rezvan Mahdavi Hezaveh
Leszek Swirski voted and added 1 comment![]( "Open in Gerrit")
Votes added by Leszek Swirski
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Leszek Swirski . resolved
Rezvan, PTAL overall (this resolves the test failures, including the new test I added)
Nico, PTAL torque -- is there a better way to access stack slots than exposing this low-level store method?
Related details
Attention is currently required from:
- Nico Hartmann
- Rezvan Mahdavi Hezaveh
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Hartmann (Gerrit)
Sep 25, 2025, 11:30:57 AM (yesterday) Sep 25
to Leszek Swirski, Rezvan Mahdavi Hezaveh, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Leszek Swirski and Rezvan Mahdavi Hezaveh
Nico Hartmann voted and added 2 comments![]( "Open in Gerrit")
Votes added by Nico Hartmann
| Code-Review | +1 |
Leszek Swirski . resolved
Rezvan, PTAL overall (this resolves the test failures, including the new test I added)
Nico, PTAL torque -- is there a better way to access stack slots than exposing this low-level store method?
Nico Hartmann
Maybe take a look at what the LocationAllocator in js-to-wasm.tq is doing, but I'm not sure that this is any better.
Related details
Attention is currently required from:
- Leszek Swirski
- Rezvan Mahdavi Hezaveh
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rezvan Mahdavi Hezaveh (Gerrit)
Sep 25, 2025, 1:55:11 PM (yesterday) Sep 25
to Leszek Swirski, Nico Hartmann, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Leszek Swirski
Rezvan Mahdavi Hezaveh voted and added 1 comment![]( "Open in Gerrit")
Votes added by Rezvan Mahdavi Hezaveh
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Rezvan Mahdavi Hezaveh . resolved
lgtm, thanks Leszek for digging into the problem and fixing it!
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages