Sparkplug+: add typed StrictEqual code stubs [v8/v8 : main]
0 views
Skip to first unread message
Wei, Yuheng (Gerrit)
Nov 12, 2025, 2:50:59 AM11/12/25
to leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org
Message from Wei, Yuheng![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Nov 12, 2025, 3:18:51 AM11/12/25
to Wei, Yuheng, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org
Attention needed from Wei, Yuheng
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
😿 Job win-11-perf/speedometer3 failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/17b0914c310000
Related details
Attention is currently required from:
- Wei, Yuheng
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wei, Yuheng (Gerrit)
Dec 1, 2025, 2:23:52 AM12/1/25
to Toon Verwaest, Leszek Swirski, Xu, Hao A, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org
Attention needed from Leszek Swirski and Toon Verwaest
Wei, Yuheng added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 9 (Latest):
Wei, Yuheng . resolved
This change is ready for review, PTAL!
Related details
Attention is currently required from:
- Leszek Swirski
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Dec 3, 2025, 8:15:49 AM12/3/25
to Wei, Yuheng, Toon Verwaest, Xu, Hao A, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org
Attention needed from Toon Verwaest and Wei, Yuheng
Leszek Swirski added 7 comments![]( "Open in Gerrit")
Patchset-level comments
File src/builtins/builtins-number-gen.cc
Line 416, Patchset 10 (Latest):
GotoIf(TaggedIsSmi(rhs), &fallback); \Leszek Swirski . unresolved
you can save a branch on the positive case by doing the rhs Smi check after, in if_notequal.
Line 578, Patchset 10 (Latest):
GotoIf(TaggedIsSmi(lhs), &fallback);
GotoIf(TaggedIsSmi(rhs), &fallback);Leszek Swirski . unresolved
also here.
Line 580, Patchset 10 (Latest):
GotoIfNot(IsStringInstanceType(LoadInstanceType(CAST(lhs))), &fallback);Leszek Swirski . unresolved
use IsString, it's faster when static roots are enabled (allows comparing the map pointer directly instead of the instance type).
Line 591, Patchset 10 (Latest):
GotoIfNot(IsStringInstanceType(LoadInstanceType(CAST(rhs))), &fallback);Leszek Swirski . unresolved
also here
File src/codegen/code-stub-assembler.cc
Line 8607, Patchset 10 (Latest):
TNode<BoolT> CodeStubAssembler::IsSymbol(TNode<HeapObject> object) {Leszek Swirski . unresolved
don't we already expose an IsSymbol via torque?
Line 8620, Patchset 10 (Latest):
TNode<BoolT> CodeStubAssembler::IsInternalizedString(TNode<HeapObject> object) {Leszek Swirski . unresolved
please add an IsInternalizedStringMap and use that, you can use a similar range check to IsSequentialStringMap
Related details
Attention is currently required from:
- Toon Verwaest
- Wei, Yuheng
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wei, Yuheng (Gerrit)
Dec 4, 2025, 3:28:10 AM12/4/25
to Toon Verwaest, Leszek Swirski, Xu, Hao A, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org
Attention needed from Leszek Swirski and Toon Verwaest
Wei, Yuheng added 6 comments![]( "Open in Gerrit")
File src/builtins/builtins-number-gen.cc
you can save a branch on the positive case by doing the rhs Smi check after, in if_notequal.
Wei, Yuheng
Done
Line 578, Patchset 10:
GotoIf(TaggedIsSmi(lhs), &fallback);
GotoIf(TaggedIsSmi(rhs), &fallback);Leszek Swirski . resolved
Wei, Yuhengalso here.
Done
Line 580, Patchset 10:
GotoIfNot(IsStringInstanceType(LoadInstanceType(CAST(lhs))), &fallback);Leszek Swirski . resolved
use IsString, it's faster when static roots are enabled (allows comparing the map pointer directly instead of the instance type).
Wei, Yuheng
Done
Line 591, Patchset 10:
GotoIfNot(IsStringInstanceType(LoadInstanceType(CAST(rhs))), &fallback);Leszek Swirski . resolved
Wei, Yuhengalso here
Done
File src/codegen/code-stub-assembler.cc
Line 8607, Patchset 10:
TNode<BoolT> CodeStubAssembler::IsSymbol(TNode<HeapObject> object) {Leszek Swirski . resolved
don't we already expose an IsSymbol via torque?
Wei, Yuheng
Done, I missed the tq exposed one.
Line 8620, Patchset 10:
TNode<BoolT> CodeStubAssembler::IsInternalizedString(TNode<HeapObject> object) {Leszek Swirski . unresolved
please add an IsInternalizedStringMap and use that, you can use a similar range check to IsSequentialStringMap
Attention is currently required from:
- Leszek Swirski
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Dec 4, 2025, 6:55:35 AM12/4/25
to Wei, Yuheng, Toon Verwaest, Xu, Hao A, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org
Attention needed from Toon Verwaest and Wei, Yuheng
Leszek Swirski voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Toon Verwaest
- Wei, Yuheng
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wei, Yuheng (Gerrit)
Dec 8, 2025, 12:50:18 AM12/8/25
to Leszek Swirski, Toon Verwaest, Xu, Hao A, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org
Attention needed from Toon Verwaest
Wei, Yuheng added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 12 (Latest):
Wei, Yuheng . resolved
A [CL](https://chromium-review.googlesource.com/c/v8/v8/+/7220204) that enables the `sparkplug_plus` flag for try job, to ensure that we have not introduced any correctness issues.
File src/codegen/code-stub-assembler.cc
Line 8620, Patchset 10:
TNode<BoolT> CodeStubAssembler::IsInternalizedString(TNode<HeapObject> object) {Leszek Swirski . resolved
Wei, Yuhengplease add an IsInternalizedStringMap and use that, you can use a similar range check to IsSequentialStringMap
Done, please help take another look.
Wei, Yuheng
Marked as resolved.
Related details
Attention is currently required from:
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wei, Yuheng (Gerrit)
Dec 8, 2025, 12:57:34 AM12/8/25
to Leszek Swirski, Toon Verwaest, Xu, Hao A, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org
Attention needed from Toon Verwaest
Wei, Yuheng added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Wei, Yuheng . resolved
I need one more +1 to submit this patch. Hi Toon, PTAL :) @verw...@chromium.org
Related details
Attention is currently required from:
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Toon Verwaest (Gerrit)
Dec 9, 2025, 9:47:51 AM12/9/25
to Wei, Yuheng, Leszek Swirski, Xu, Hao A, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org
Attention needed from Wei, Yuheng
Toon Verwaest voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Wei, Yuheng
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wei, Yuheng (Gerrit)
Dec 9, 2025, 9:14:22 PM12/9/25
to Toon Verwaest, Leszek Swirski, Xu, Hao A, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org
Wei, Yuheng voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wei, Yuheng (Gerrit)
Dec 10, 2025, 12:14:35 AM12/10/25
to Toon Verwaest, Leszek Swirski, Xu, Hao A, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org
Attention needed from Leszek Swirski and Toon Verwaest
Wei, Yuheng added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 13 (Latest):
Wei, Yuheng . resolved
Rebase and resolve merge conflict. Please help +1 again :)
Related details
Attention is currently required from:
- Leszek Swirski
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Dec 10, 2025, 4:38:12 AM12/10/25
to Wei, Yuheng, Toon Verwaest, Xu, Hao A, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org
Attention needed from Toon Verwaest and Wei, Yuheng
Leszek Swirski voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Toon Verwaest
- Wei, Yuheng
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xu, Hao A (Gerrit)
Dec 10, 2025, 10:17:52 PM12/10/25
to Wei, Yuheng, Leszek Swirski, Toon Verwaest, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org
Attention needed from Toon Verwaest and Wei, Yuheng
Xu, Hao A voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Toon Verwaest
- Wei, Yuheng
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wei, Yuheng (Gerrit)
Dec 10, 2025, 10:59:04 PM12/10/25
to Xu, Hao A, Leszek Swirski, Toon Verwaest, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org
Attention needed from Toon Verwaest
Wei, Yuheng voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Dec 10, 2025, 11:48:32 PM12/10/25
to Wei, Yuheng, Xu, Hao A, Leszek Swirski, Toon Verwaest, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Sparkplug+: add typed StrictEqual code stubs
Introduces specialized small handlers for frequent types in baseline
StrictEqual. On an input type mismatch, it attempts to patch to another
typed handler or falls back to the generic handler.
Bug: chromium:429351411
Change-Id: I04a10885d8df5f6a78b3b3dfd31c60c89c6c3ba0
Commit-Queue: Wei, Yuheng <yuhen...@intel.com>
Reviewed-by: Leszek Swirski <les...@chromium.org>
Reviewed-by: Xu, Hao A <hao....@intel.com>
Cr-Commit-Position: refs/heads/main@{#104261}
Files:
- M src/baseline/baseline-compiler.cc
- M src/builtins/builtins-definitions.h
- M src/builtins/builtins-number-gen.cc
- M src/codegen/arm64/interface-descriptors-arm64-inl.h
- M src/codegen/code-stub-assembler.cc
- M src/codegen/code-stub-assembler.h
- M src/codegen/interface-descriptors.h
- M src/codegen/x64/interface-descriptors-x64-inl.h
- M src/common/globals.h
- M src/runtime/runtime-compiler.cc
- M src/runtime/runtime.h
Change size: L
Delta: 11 files changed, 451 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Leszek Swirski, +1 by Xu, Hao A
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages