Introduce `V8_NO_SANITIZE_ARRAY_BOUNDS` [v8/v8 : main]

0 views
Skip to first unread message

David Benjamin (Gerrit)

unread,
Oct 22, 2025, 2:09:52 PM (21 hours ago) Oct 22
to Kalvin Lee, v8-re...@googlegroups.com
Attention needed from Kalvin Lee

David Benjamin added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
David Benjamin . resolved

A quick drive-by thought: this would disable the sanitizer on all builds, but we probably only want to disable it for release builds. The UBSan build should still check this.

A couple possibilities:

1. Gate this on some #define that we set in the build alongside array-bounds-for-release

2. Use `__builtin_assume(...)` on whatever invariant the compiler is failing to discover. `-fsanitize=builtin`, enabled by the testing UBSan build, will then check this while release builds can tell the compiler about this.

Open in Gerrit

Related details

Attention is currently required from:
  • Kalvin Lee
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5f3a45b4c696e0d579e9981824525e16b2fa220d
Gerrit-Change-Number: 7006054
Gerrit-PatchSet: 1
Gerrit-Owner: Kalvin Lee <kd...@chromium.org>
Gerrit-CC: David Benjamin <davi...@chromium.org>
Gerrit-Attention: Kalvin Lee <kd...@chromium.org>
Gerrit-Comment-Date: Wed, 22 Oct 2025 18:09:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages