[turboshaft] Constant-fold TaggedEqual(Smi, HeapObject) to false [v8/v8 : main]

0 views
Skip to first unread message

Darius Mercadier (Gerrit)

unread,
1:59 AM (9 hours ago) 1:59 AM
to Nico Hartmann, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Nico Hartmann

Darius Mercadier voted and added 1 comment

Votes added by Darius Mercadier

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Darius Mercadier . resolved

PTAL! :)

Open in Gerrit

Related details

Attention is currently required from:
  • Nico Hartmann
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I8898c64f18050908d4559556241e672c579f9432
Gerrit-Change-Number: 7452249
Gerrit-PatchSet: 1
Gerrit-Owner: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Attention: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 06:58:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nico Hartmann (Gerrit)

unread,
4:21 AM (7 hours ago) 4:21 AM
to Darius Mercadier, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Darius Mercadier

Nico Hartmann voted and added 1 comment

Votes added by Nico Hartmann

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Nico Hartmann . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Darius Mercadier
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I8898c64f18050908d4559556241e672c579f9432
Gerrit-Change-Number: 7452249
Gerrit-PatchSet: 1
Gerrit-Owner: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Attention: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 09:21:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
4:23 AM (7 hours ago) 4:23 AM
to Darius Mercadier, Nico Hartmann, dmercadi...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[turboshaft] Constant-fold TaggedEqual(Smi, HeapObject) to false
Bug: 431933185
Change-Id: I8898c64f18050908d4559556241e672c579f9432
Reviewed-by: Nico Hartmann <nicoha...@chromium.org>
Auto-Submit: Darius Mercadier <dmerc...@chromium.org>
Commit-Queue: Nico Hartmann <nicoha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104657}
Files:
  • M src/compiler/turboshaft/machine-optimization-reducer.h
  • A test/mjsunit/turbolev/load-constant-holey-array.js
Change size: S
Delta: 2 files changed, 24 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nico Hartmann
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I8898c64f18050908d4559556241e672c579f9432
Gerrit-Change-Number: 7452249
Gerrit-PatchSet: 2
Gerrit-Owner: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages