[turboshaft] Constant-fold TaggedEqual(Smi, HeapObject) to false [v8/v8 : main]
0 views
Skip to first unread message
Darius Mercadier (Gerrit)
1:59 AM (9 hours ago) 1:59 AM
to Nico Hartmann, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Nico Hartmann
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Nico Hartmann
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Hartmann (Gerrit)
4:21 AM (7 hours ago) 4:21 AM
to Darius Mercadier, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Darius Mercadier
Nico Hartmann voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nico Hartmann
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
4:23 AM (7 hours ago) 4:23 AM
to Darius Mercadier, Nico Hartmann, dmercadi...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[turboshaft] Constant-fold TaggedEqual(Smi, HeapObject) to false
Bug: 431933185
Change-Id: I8898c64f18050908d4559556241e672c579f9432
Reviewed-by: Nico Hartmann <nicoha...@chromium.org>
Auto-Submit: Darius Mercadier <dmerc...@chromium.org>
Commit-Queue: Nico Hartmann <nicoha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104657}
Files:
- M src/compiler/turboshaft/machine-optimization-reducer.h
- A test/mjsunit/turbolev/load-constant-holey-array.js
Change size: S
Delta: 2 files changed, 24 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nico Hartmann
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages