[regexp] Don't need the FilterOneByte pass. [v8/v8 : main]
0 views
Skip to first unread message
chromeperf@appspot.gserviceaccount.com (Gerrit)
Dec 18, 2025, 2:25:22 PM12/18/25
to Erik Corry, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m4-mini-perf/jetstream2.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/15cc59bcb10000
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Erik Corry (Gerrit)
Dec 22, 2025, 8:54:06 AM12/22/25
to Jakob Linke, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Linke
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
Jan 8, 2026, 8:45:06 AM (22 hours ago) Jan 8
to Erik Corry, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Erik Corry
Jakob Linke voted and added 2 comments![]( "Open in Gerrit")
Votes added by Jakob Linke
| Code-Review | +1 |
2 comments
File src/regexp/regexp-compiler-tonode.cc
Line 50, Patchset 5 (Latest):
if (compiler->one_byte() && !result->CanMatchLatin1(compiler)) {Jakob Linke . unresolved
I like the graph pruning approach, but it'd be great to bottleneck this and related patterns nicely. Ideas for factory methods or macros that encapsulate the "construct-or-prune-if" pattern?
Fine to land as is, but let's keep this in mind.
Line 2106, Patchset 5 (Latest):
if (body_node->IsBacktrack()) {Jakob Linke . unresolved
Please add a comment like above and below.
Related details
Attention is currently required from:
- Erik Corry
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Erik Corry (Gerrit)
Jan 8, 2026, 9:36:47 AM (21 hours ago) Jan 8
to Jakob Linke, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, jgrube...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Erik Corry added 1 comment![]( "Open in Gerrit")
File src/regexp/regexp-compiler-tonode.cc
Please add a comment like above and below.
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages