v8-ci-autoroll-builder would like Olivier Flückiger and Rezvan Mahdavi Hezaveh to review this change.
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/d2940bdb..9adf3c0c
Roll created at https://cr-buildbucket.appspot.com/build/8699351628770134305
no-export: true
R=ol...@chromium.org,rez...@chromium.org
diff --git a/DEPS b/DEPS
index 5b08d6c2..fdbc614 100644
--- a/DEPS
+++ b/DEPS
@@ -182,7 +182,7 @@
'test/mozilla/data':
Var('chromium_url') + '/v8/deps/third_party/mozilla-tests.git' + '@' + 'f6c578a10ea707b1a8ab0b88943fe5115ce2b9be',
'test/test262/data':
- Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + 'd2940bdbb0e28fd002ec31b89f8182bbf63da092',
+ Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + '9adf3c0c2fc42efa1f72bc4f2827dc005d05f458',
'third_party/android_platform': {
'url': Var('chromium_url') + '/chromium/src/third_party/android_platform.git' + '@' + 'e3919359f2387399042d31401817db4a02d756ec',
'condition': 'checkout_android',
diff --git a/test/test262/local-tests/test/staging/features.txt b/test/test262/local-tests/test/staging/features.txt
index a47a44b..f48d541 100644
--- a/test/test262/local-tests/test/staging/features.txt
+++ b/test/test262/local-tests/test/staging/features.txt
@@ -11,6 +11,10 @@
#
# https://github.com/tc39/process-document
+# Intl Era Monthcode
+# https://github.com/tc39/proposal-intl-era-monthcode
+Intl.Era-monthcode
+
# Intl.Locale Info
# https://github.com/tc39/proposal-intl-locale-info
Intl.Locale-info
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Commit-Queue | +2 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Commit-Queue | +2 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/d2940bdb..9adf3c0c
Roll created at https://cr-buildbucket.appspot.com/build/8699351628770134305
no-export: true
R=ol...@chromium.org,rez...@chromium.org
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-ci-autoroll-builder would like Olivier Flückiger and Rezvan Mahdavi Hezaveh to review this change.
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/9adf3c0c..80d1f6dc
Roll created at https://cr-buildbucket.appspot.com/build/8698717450304226161
no-export: true
R=ol...@chromium.org,rez...@chromium.org
diff --git a/DEPS b/DEPS
index dbe183f..6a23a11 100644
--- a/DEPS
+++ b/DEPS
@@ -182,7 +182,7 @@
'test/mozilla/data':
Var('chromium_url') + '/v8/deps/third_party/mozilla-tests.git' + '@' + 'f6c578a10ea707b1a8ab0b88943fe5115ce2b9be',
'test/test262/data':
- Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + '9adf3c0c2fc42efa1f72bc4f2827dc005d05f458',
+ Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + '80d1f6dc892f45257488b052c0870c9852824cb1',
'third_party/android_platform': {
'url': Var('chromium_url') + '/chromium/src/third_party/android_platform.git' + '@' + 'e3919359f2387399042d31401817db4a02d756ec',
'condition': 'checkout_android',
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yep, these are new tests testing some currently cross-browser incompatible behavior, see https://github.com/boa-dev/temporal/issues/613
Thanks!
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Commit-Queue | +2 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/9adf3c0c..80d1f6dc
Roll created at https://cr-buildbucket.appspot.com/build/8698717450304226161
More context:
https://github.com/tc39/test262/issues/4638
https://github.com/tc39/test262/pull/4650
no-export: true
R=ol...@chromium.org,rez...@chromium.org
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-ci-autoroll-builder would like Olivier Flückiger and Rezvan Mahdavi Hezaveh to review this change.
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/80d1f6dc..f95832e7
Roll created at https://cr-buildbucket.appspot.com/build/8698083272478713601
no-export: true
R=ol...@chromium.org,rez...@chromium.org
diff --git a/DEPS b/DEPS
index 67921ff..97e1f3e 100644
--- a/DEPS
+++ b/DEPS
@@ -182,7 +182,7 @@
'test/mozilla/data':
Var('chromium_url') + '/v8/deps/third_party/mozilla-tests.git' + '@' + 'f6c578a10ea707b1a8ab0b88943fe5115ce2b9be',
'test/test262/data':
- Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + '80d1f6dc892f45257488b052c0870c9852824cb1',
+ Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + 'f95832e793861fddbb2b84861c05fd21706adf6c',
'third_party/android_platform': {
'url': Var('chromium_url') + '/chromium/src/third_party/android_platform.git' + '@' + 'e3919359f2387399042d31401817db4a02d756ec',
'condition': 'checkout_android',
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Manish fyi
Every time I'm one step away from 100% test coverage they add more tests for me to fail. I'll investigate tomorrow, I suspect this has to do with some of the previously-underspecified leap month arithmetic behavior.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Manish GoregaokarManish fyi
Every time I'm one step away from 100% test coverage they add more tests for me to fail. I'll investigate tomorrow, I suspect this has to do with some of the previously-underspecified leap month arithmetic behavior.
First failure is Intl, not Temporal, filed b/461483447
Working on the other Temporal failures now.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/80d1f6dc..f95832e7
Roll created at https://cr-buildbucket.appspot.com/build/8698083272478713601
no-export: true
R=ol...@chromium.org,rez...@chromium.org
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-ci-autoroll-builder would like Olivier Flückiger and Rezvan Mahdavi Hezaveh to review this change.
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/f95832e7..3aa75310
Roll created at https://cr-buildbucket.appspot.com/build/8697449092544247169
no-export: true
R=ol...@chromium.org,rez...@chromium.org
diff --git a/DEPS b/DEPS
index c10d0f8..74a6d69 100644
--- a/DEPS
+++ b/DEPS
@@ -182,7 +182,7 @@
'test/mozilla/data':
Var('chromium_url') + '/v8/deps/third_party/mozilla-tests.git' + '@' + 'f6c578a10ea707b1a8ab0b88943fe5115ce2b9be',
'test/test262/data':
- Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + 'f95832e793861fddbb2b84861c05fd21706adf6c',
+ Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + '3aa75310772673da078ca1d96fe3b75da0e21bd0',
'third_party/android_platform': {
'url': Var('chromium_url') + '/chromium/src/third_party/android_platform.git' + '@' + 'e3919359f2387399042d31401817db4a02d756ec',
'condition': 'checkout_android',
diff --git a/test/test262/test262.status b/test/test262/test262.status
index e1f4245..a60dc98 100644
--- a/test/test262/test262.status
+++ b/test/test262/test262.status
@@ -255,8 +255,6 @@
'staging/sm/Temporal/*': [SKIP],
# Test errors for out-of-ground-truth-range calendars (expected, test is broken: https://github.com/tc39/test262/issues/4614)
- 'staging/Intl402/Temporal/old/non-iso-calendars-chinese': [FAIL],
- 'staging/Intl402/Temporal/old/non-iso-calendars-dangi': [FAIL],
'intl402/Temporal/PlainYearMonth/from/reference-day-chinese': [FAIL],
# Newly added arithmetic tests
@@ -588,8 +586,6 @@
'staging/Intl402/Temporal/old/non-iso-calendars-roc': [SKIP],
# Somehow passes on Android (b/433933898):
- 'staging/Intl402/Temporal/old/non-iso-calendars-chinese': [SKIP],
- 'staging/Intl402/Temporal/old/non-iso-calendars-dangi': [SKIP],
}], # 'system == android'
['arch == arm or arch == arm64 or arch == mips64 or arch == mips64el', {
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
FYI Manish. Also can you please +1 this?
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Commit-Queue | +1 |
Thanks. Unsure what the new failures are about, will check out.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
'built-ins/Temporal/Duration/prototype/round/rounding-window': [SKIP],hmm, copying this test into tree locally seems to succeed.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Are `intl402/` tests related to your code or Frank's?
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Are `intl402/` tests related to your code or Frank's?
Both! intl402/ is Frank unless it is intl402/Temporal. If people want me to look at specific Intl bugs I'm still happy to do so though!
The distinction is about internationalization support: all of Intl is "internationalization", but only some of Temporal is. ISO calendar datetime operations, *without timezone support*, is "non-i18n Temporal", and it is IIRC conformant for an engine to just support that. Full Temporal support involves non-Gregorian calendars and timezone handling, which is tested under intl402/.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Manish GoregaokarAre `intl402/` tests related to your code or Frank's?
Both! intl402/ is Frank unless it is intl402/Temporal. If people want me to look at specific Intl bugs I'm still happy to do so though!
The distinction is about internationalization support: all of Intl is "internationalization", but only some of Temporal is. ISO calendar datetime operations, *without timezone support*, is "non-i18n Temporal", and it is IIRC conformant for an engine to just support that. Full Temporal support involves non-Gregorian calendars and timezone handling, which is tested under intl402/.
I see. Thanks for the clarification!
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Manish GoregaokarAre `intl402/` tests related to your code or Frank's?
Rezvan Mahdavi HezavehBoth! intl402/ is Frank unless it is intl402/Temporal. If people want me to look at specific Intl bugs I'm still happy to do so though!
The distinction is about internationalization support: all of Intl is "internationalization", but only some of Temporal is. ISO calendar datetime operations, *without timezone support*, is "non-i18n Temporal", and it is IIRC conformant for an engine to just support that. Full Temporal support involves non-Gregorian calendars and timezone handling, which is tested under intl402/.
I see. Thanks for the clarification!
Just created two bugs and assigned them to you and Frank.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/f95832e7..3aa75310
Roll created at https://cr-buildbucket.appspot.com/build/8697449092544247169
no-export: true
R=ol...@chromium.org,rez...@chromium.org
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-ci-autoroll-builder would like Olivier Flückiger and Rezvan Mahdavi Hezaveh to review this change.
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/9abd5220..d0994d64
Roll created at https://cr-buildbucket.appspot.com/build/8696814914993817185
no-export: true
R=ol...@chromium.org,rez...@chromium.org
diff --git a/DEPS b/DEPS
index 86b6f8c..bdaa5bd 100644
--- a/DEPS
+++ b/DEPS
@@ -182,7 +182,7 @@
'test/mozilla/data':
Var('chromium_url') + '/v8/deps/third_party/mozilla-tests.git' + '@' + 'f6c578a10ea707b1a8ab0b88943fe5115ce2b9be',
'test/test262/data':
- Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + '9abd522060e1cd0c15be60c9945f56f7dbb32641',
+ Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + 'd0994d64b07cb6c164dd9f345c94ed797a53d69f',
'third_party/android_platform': {
'url': Var('chromium_url') + '/chromium/src/third_party/android_platform.git' + '@' + 'e3919359f2387399042d31401817db4a02d756ec',
'condition': 'checkout_android',
diff --git a/test/test262/local-tests/test/staging/features.txt b/test/test262/local-tests/test/staging/features.txt
index f48d541..065eb25 100644
--- a/test/test262/local-tests/test/staging/features.txt
+++ b/test/test262/local-tests/test/staging/features.txt
@@ -88,6 +88,10 @@
# https://github.com/tc39/proposal-nonextensible-applies-to-private
nonextensible-applies-to-private
+# Joint Iteration
+# https://github.com/tc39/proposal-joint-iteration
+joint-iteration
+
## Standard language features
#
# Language features that have been included in a published version of the
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Just opened two crbug for failed tests.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Commit-Queue | +2 |
Just opened two crbug for failed tests.
thanks.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/9abd5220..d0994d64
Roll created at https://cr-buildbucket.appspot.com/build/8696814914993817185
no-export: true
R=ol...@chromium.org,rez...@chromium.org
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-ci-autoroll-builder would like Olivier Flückiger and Rezvan Mahdavi Hezaveh to review this change.
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/23ec670d..f866b4bc
Roll created at https://cr-buildbucket.appspot.com/build/8696180735418762817
no-export: true
R=ol...@chromium.org,rez...@chromium.org
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/23ec670d..f866b4bc
Roll created at https://cr-buildbucket.appspot.com/build/8696180735418762817
no-export: true
R=ol...@chromium.org,rez...@chromium.org
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-ci-autoroll-builder would like Olivier Flückiger and Rezvan Mahdavi Hezaveh to review this change.
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/c0cf5277..947fee33
Roll created at https://cr-buildbucket.appspot.com/build/8695546557221648097
no-export: true
R=ol...@chromium.org,rez...@chromium.org
diff --git a/DEPS b/DEPS
index 26110cf..819a3c0 100644
--- a/DEPS
+++ b/DEPS
@@ -182,7 +182,7 @@
'test/mozilla/data':
Var('chromium_url') + '/v8/deps/third_party/mozilla-tests.git' + '@' + 'f6c578a10ea707b1a8ab0b88943fe5115ce2b9be',
'test/test262/data':
- Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + 'c0cf527756840ae8ba679e53e627ec20f3bbc5c8',
+ Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + '947fee33f81e261afd4fc6020b2a1d3ac23efa60',
'third_party/android_platform': {
'url': Var('chromium_url') + '/chromium/src/third_party/android_platform.git' + '@' + 'e3919359f2387399042d31401817db4a02d756ec',
'condition': 'checkout_android',
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/c0cf5277..947fee33
Roll created at https://cr-buildbucket.appspot.com/build/8695546557221648097
no-export: true
R=ol...@chromium.org,rez...@chromium.org
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
+manish fyi
Thanks! Should all be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/7261567
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |