heap: erase(std::remove(...)) -> std::erase(...) [v8/v8 : main]

0 views
Skip to first unread message

Elly FJ (Gerrit)

unread,
Dec 11, 2025, 7:10:45 PM (5 days ago) Dec 11
to Elly FJ, Deepti Gandluri, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Deepti Gandluri

Elly FJ added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Elly FJ . resolved

gdeepti: please have a look? :)

Open in Gerrit

Related details

Attention is currently required from:
  • Deepti Gandluri
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I8840e25a51b9cd1b943cb87a9c0581ac674afc7d
Gerrit-Change-Number: 7254491
Gerrit-PatchSet: 1
Gerrit-Owner: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: Deepti Gandluri <gde...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Deepti Gandluri <gde...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Dec 2025 00:10:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
Dec 15, 2025, 4:30:15 AM (yesterday) Dec 15
to Elly FJ, Deepti Gandluri, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Deepti Gandluri and Elly FJ

Michael Lippautz voted and added 1 comment

Votes added by Michael Lippautz

Code-Review+1

1 comment

Patchset-level comments
Michael Lippautz . resolved

let me help here

Open in Gerrit

Related details

Attention is currently required from:
  • Deepti Gandluri
  • Elly FJ
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I8840e25a51b9cd1b943cb87a9c0581ac674afc7d
Gerrit-Change-Number: 7254491
Gerrit-PatchSet: 1
Gerrit-Owner: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: Deepti Gandluri <gde...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Elly FJ <elly...@chromium.org>
Gerrit-Attention: Deepti Gandluri <gde...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 09:30:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Elly FJ (Gerrit)

unread,
Dec 15, 2025, 11:22:29 AM (21 hours ago) Dec 15
to Elly FJ, Michael Lippautz, Deepti Gandluri, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Deepti Gandluri

Elly FJ voted and added 1 comment

Votes added by Elly FJ

Commit-Queue+2

1 comment

Patchset-level comments
Elly FJ . resolved

thanks mlippautz! -> cq :)

Open in Gerrit

Related details

Attention is currently required from:
  • Deepti Gandluri
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I8840e25a51b9cd1b943cb87a9c0581ac674afc7d
Gerrit-Change-Number: 7254491
Gerrit-PatchSet: 1
Gerrit-Owner: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: Deepti Gandluri <gde...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Deepti Gandluri <gde...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 16:22:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages