Update lucicfg version [v8/v8 : infra/config]

1 view
Skip to first unread message

Michael Achenbach (Gerrit)

unread,
Oct 30, 2021, 10:41:35 AM10/30/21
to Liviu Rau, Almothana Athamneh, Vadim Shtayura, v8-re...@googlegroups.com

Attention is currently required from: Almothana Athamneh, Liviu Rau.

View Change

1 comment:

To view, visit change 3251025. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: v8/v8
Gerrit-Branch: infra/config
Gerrit-Change-Id: Idb050c6852475b3bfaa6a20998bec216ac92203a
Gerrit-Change-Number: 3251025
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Achenbach <mache...@chromium.org>
Gerrit-Reviewer: Almothana Athamneh <almut...@chromium.org>
Gerrit-Reviewer: Liviu Rau <livi...@chromium.org>
Gerrit-CC: Vadim Shtayura <vad...@chromium.org>
Gerrit-Attention: Almothana Athamneh <almut...@chromium.org>
Gerrit-Attention: Liviu Rau <livi...@chromium.org>
Gerrit-Comment-Date: Sat, 30 Oct 2021 14:41:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Michael Achenbach (Gerrit)

unread,
Oct 30, 2021, 10:41:47 AM10/30/21
to Liviu Rau, Almothana Athamneh, Vadim Shtayura, v8-re...@googlegroups.com

Attention is currently required from: Almothana Athamneh, Liviu Rau.

Patch set 1:Auto-Submit +1Commit-Queue +1

View Change

    To view, visit change 3251025. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: v8/v8
    Gerrit-Branch: infra/config
    Gerrit-Change-Id: Idb050c6852475b3bfaa6a20998bec216ac92203a
    Gerrit-Change-Number: 3251025
    Gerrit-PatchSet: 1
    Gerrit-Owner: Michael Achenbach <mache...@chromium.org>
    Gerrit-Reviewer: Almothana Athamneh <almut...@chromium.org>
    Gerrit-Reviewer: Liviu Rau <livi...@chromium.org>
    Gerrit-Reviewer: Michael Achenbach <mache...@chromium.org>
    Gerrit-CC: Vadim Shtayura <vad...@chromium.org>
    Gerrit-Attention: Almothana Athamneh <almut...@chromium.org>
    Gerrit-Attention: Liviu Rau <livi...@chromium.org>
    Gerrit-Comment-Date: Sat, 30 Oct 2021 14:41:40 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Liviu Rau (Gerrit)

    unread,
    Nov 2, 2021, 5:01:02 AM11/2/21
    to Michael Achenbach, V8 LUCI CQ, Almothana Athamneh, Vadim Shtayura, v8-re...@googlegroups.com

    Attention is currently required from: Almothana Athamneh, Michael Achenbach.

    Patch set 1:Code-Review +1Commit-Queue +2

    View Change

      To view, visit change 3251025. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: v8/v8
      Gerrit-Branch: infra/config
      Gerrit-Change-Id: Idb050c6852475b3bfaa6a20998bec216ac92203a
      Gerrit-Change-Number: 3251025
      Gerrit-PatchSet: 1
      Gerrit-Owner: Michael Achenbach <mache...@chromium.org>
      Gerrit-Reviewer: Almothana Athamneh <almut...@chromium.org>
      Gerrit-Reviewer: Liviu Rau <livi...@chromium.org>
      Gerrit-Reviewer: Michael Achenbach <mache...@chromium.org>
      Gerrit-CC: Vadim Shtayura <vad...@chromium.org>
      Gerrit-Attention: Almothana Athamneh <almut...@chromium.org>
      Gerrit-Attention: Michael Achenbach <mache...@chromium.org>
      Gerrit-Comment-Date: Tue, 02 Nov 2021 09:00:53 +0000

      V8 LUCI CQ (Gerrit)

      unread,
      Nov 2, 2021, 5:03:03 AM11/2/21
      to Michael Achenbach, Liviu Rau, Almothana Athamneh, Vadim Shtayura, v8-re...@googlegroups.com

      V8 LUCI CQ submitted this change.

      View Change


      Approvals: Liviu Rau: Looks good to me; Commit Michael Achenbach: Send CL to CQ automatically after approval
      Update lucicfg version

      Change-Id: Idb050c6852475b3bfaa6a20998bec216ac92203a
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3251025
      Auto-Submit: Michael Achenbach <mache...@chromium.org>
      Commit-Queue: Liviu Rau <livi...@chromium.org>
      Reviewed-by: Liviu Rau <livi...@chromium.org>
      ---
      M main.star
      M generated/project.cfg
      2 files changed, 20 insertions(+), 1 deletion(-)

      diff --git a/generated/project.cfg b/generated/project.cfg
      index 31ce39c..90db176 100644
      --- a/generated/project.cfg
      +++ b/generated/project.cfg
      @@ -6,3 +6,9 @@

      name: "v8"
      access: "group:all"
      +lucicfg {
      + version: "1.29.1"
      + package_dir: ".."
      + config_dir: "generated"
      + entry_point: "main.star"
      +}
      diff --git a/main.star b/main.star
      index d819866..9ff07d1 100755
      --- a/main.star
      +++ b/main.star
      @@ -3,7 +3,7 @@
      # Use of this source code is governed by a BSD-style license that can be
      # found in the LICENSE file.

      -lucicfg.check_version("1.23.3", "Please update depot_tools")
      +lucicfg.check_version("1.29.1", "Please update depot_tools")

      load(
      "//lib/lib.star",

      To view, visit change 3251025. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: v8/v8
      Gerrit-Branch: infra/config
      Gerrit-Change-Id: Idb050c6852475b3bfaa6a20998bec216ac92203a
      Gerrit-Change-Number: 3251025
      Gerrit-PatchSet: 2
      Gerrit-Owner: Michael Achenbach <mache...@chromium.org>
      Gerrit-Reviewer: Almothana Athamneh <almut...@chromium.org>
      Gerrit-Reviewer: Liviu Rau <livi...@chromium.org>
      Gerrit-Reviewer: Michael Achenbach <mache...@chromium.org>
      Gerrit-CC: Vadim Shtayura <vad...@chromium.org>
      Gerrit-MessageType: merged
      Reply all
      Reply to author
      Forward
      0 new messages