[compiler][arm64] Dot I8x8 [v8/v8 : main]
0 views
Skip to first unread message
Sam Parker-Haynes (Gerrit)
Jan 8, 2026, 11:15:49 AM (yesterday) Jan 8
to Matthias Liedtke, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke
Sam Parker-Haynes voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Matthias Liedtke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthias Liedtke (Gerrit)
6:11 AM (17 hours ago) 6:11 AM
to Sam Parker-Haynes, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Sam Parker-Haynes
Matthias Liedtke voted and added 2 comments![]( "Open in Gerrit")
Votes added by Matthias Liedtke
| Code-Review | +1 |
2 comments
Patchset-level comments
File src/compiler/turboshaft/operations.h
Line 8176, Patchset 2 (Latest):
return true;
case Kind::kI32x4AddPairwise:Matthias Liedtke . unresolved
Nit: No need to repeat the `return true;` here.
```suggestion
case Kind::kI32x4AddPairwise:
```
Related details
Attention is currently required from:
- Sam Parker-Haynes
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sam Parker-Haynes (Gerrit)
6:23 AM (17 hours ago) 6:23 AM
to Matthias Liedtke, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Sam Parker-Haynes added 1 comment![]( "Open in Gerrit")
File src/compiler/turboshaft/operations.h
Nit: No need to repeat the `return true;` here.
```suggestion
case Kind::kI32x4AddPairwise:
```
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sam Parker-Haynes (Gerrit)
6:50 AM (17 hours ago) 6:50 AM
to Matthias Liedtke, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Sam Parker-Haynes voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
7:25 AM (16 hours ago) 7:25 AM
to Sam Parker-Haynes, Matthias Liedtke, dmercadi...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/compiler/turboshaft/operations.h
Insertions: 0, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[compiler][arm64] Dot I8x8
When a wasm dot instruction is really operating on i8x8 data, attempt
to combine it into a single extmul and extadd_pairwise.
For AArch64, when the above is not possible, we break the dot into
two extmul and then, a newly added, I32x4AddPairwise op.
Change-Id: Ifeb68b4cdc9615d4bc549c68bc930843f7d95e6e
Commit-Queue: Sam Parker-Haynes <sam.p...@arm.com>
Reviewed-by: Matthias Liedtke <mlie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104592}
Files:
- M src/compiler/backend/arm64/code-generator-arm64.cc
- M src/compiler/backend/arm64/instruction-codes-arm64.h
- M src/compiler/backend/arm64/instruction-scheduler-arm64.cc
- M src/compiler/backend/arm64/instruction-selector-arm64.cc
- M src/compiler/backend/instruction-selector.cc
- M src/compiler/opcodes.h
- M src/compiler/turboshaft/machine-optimization-reducer.h
- M src/compiler/turboshaft/operations.h
- A test/mjsunit/wasm/simd-dot-i8.js
- M test/unittests/compiler/arm64/turboshaft-instruction-selector-arm64-unittest.cc
- M test/unittests/compiler/turboshaft/wasm-simd-unittest.cc
Change size: L
Delta: 11 files changed, 286 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Matthias Liedtke
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages